Skip to content

Conversation

@dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Jan 16, 2023

Pull Request for Issue #39646 .

Summary of Changes

When @laoneo did the PR for tinyMCE #39625 I've contacted him with this request that was left for another PR

Screenshot 2023-01-16 at 16 53 32

Testing Instructions

add these lines after

<field name="articletext1" type="editor" editor="none" buttons="true" hide="menu,module" />
<field name="articletext2" type="editor" editor="codemirror" buttons="true" hide="article,image" />

add these lines after

<?php echo $this->form->getInput('articletext'); ?>

<?php echo $this->form->getInput('articletext1'); ?>
<?php echo $this->form->getInput('articletext2'); ?>

Create a new article, tinyMCE should have all the buttons, none should miss the menu and module and codemirror should miss article and image

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@OctavianC
Copy link
Contributor

I have tested this item ✅ successfully on 4460852

Works


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39648.

@OctavianC
Copy link
Contributor

image

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 4460852

👍


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39648.

@laoneo
Copy link
Member

laoneo commented Jan 17, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39648.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 17, 2023
@roland-d roland-d merged commit 18fc8be into joomla:4.2-dev Jan 17, 2023
@roland-d
Copy link
Contributor

Thank you

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 17, 2023
@roland-d roland-d added this to the Joomla! 4.2.7 milestone Jan 17, 2023
@dgrammatiko dgrammatiko deleted the patch-5 branch January 17, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants