[4.3] Remove obsolete exclude patterns from ruleset.xml for phpcs #40276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2023
|
Thx |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This pull request (PR) removes obsolete exclude patterns from the "ruleset.xml" file which is used by phpcs e.g. in the ci tests with Drone.
Obsolete means the corresponding file or folder has been removed (or moved to another place) with some PR but the exclude pattern has been forgotten about.
In detail following entries are removed due to the mentioned PR:
The list of obsolete exclude patterns has been created with help of a small tool (PHP CLI script) which I provide with PR #40278 .
Which PR has caused each change has then been "manually" investigated by me.
Testing Instructions
Code review: Check that the removed exclude patterns belong to files mentioned in the list in the description above and the corresponding files don't exist on a clean, current 4.3-dev branch.
Verify that the PHPCS step succeeded in the Drone ci checks for this PR here.
Actual result BEFORE applying this Pull Request
File "ruleset.xml" in the Joomla root contains exclude patterns for files which don't exist anymore in the 4.3-dev branch.
Expected result AFTER applying this Pull Request
File "ruleset.xml" in the Joomla root doesn't contain these exclude patterns.
PHPCS still succeeds in Drone for this PR.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed