Skip to content

Conversation

@dgrammatiko
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

  • Move all editor buttons except page break (for testing purposes) to service providers

Testing Instructions

  • Apply the PR
  • Delete the file administrator/cache/autoload_psr4.php
  • Check that all buttons work correctly for all the editors (tinyMCE, Codemirror, None)

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo

@dgrammatiko dgrammatiko requested a review from laoneo as a code owner January 16, 2023 18:50
@dgrammatiko dgrammatiko changed the title [4.3] Converts tinymce to service providers [4.3] Converts editor buttons to service providers Jan 16, 2023
@laoneo
Copy link
Member

laoneo commented Jan 17, 2023

I'm just wondering if the namespace should be a bit more clear. I know they are inline with the rest, but Xtd doesn't say much. Why not just going with Joomla\Plugin\EditorButton\Article.

@dgrammatiko
Copy link
Contributor Author

Let’s keep the Xtd suffix, as I plan to roll a new set with the upcoming modal (dialog element) and @Fedik wants to have couple more events for the editors so the EditorsButtons would be used there

@laoneo
Copy link
Member

laoneo commented Jan 18, 2023

I have tested this item ✅ successfully on 9f0987d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39649.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 9f0987d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39649.

@Quy
Copy link
Contributor

Quy commented Jan 18, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39649.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 18, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Jan 19, 2023
@obuisard obuisard merged commit bf80bb6 into joomla:4.3-dev Jan 19, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 19, 2023
@obuisard
Copy link
Contributor

Thank you Dimitris @dgrammatiko :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants