-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.3] Converts editor buttons to service providers #39649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm just wondering if the namespace should be a bit more clear. I know they are inline with the rest, but Xtd doesn't say much. Why not just going with Joomla\Plugin\EditorButton\Article. |
|
Let’s keep the Xtd suffix, as I plan to roll a new set with the upcoming modal (dialog element) and @Fedik wants to have couple more events for the editors so the EditorsButtons would be used there |
|
I have tested this item ✅ successfully on 9f0987d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39649. |
1 similar comment
|
I have tested this item ✅ successfully on 9f0987d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39649. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39649. |
|
Thank you Dimitris @dgrammatiko :-) |
Add deleted files from PRs joomla#39379 , joomla#39539 , joomla#39624 , joomla#39649 and joomla#39625 .
Pull Request for Issue # .
Summary of Changes
Testing Instructions
administrator/cache/autoload_psr4.phpActual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
@laoneo