-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.3] Upgrade to Bootstrap 5.2 #39379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Hannes Papenberg <[email protected]>
|
Tested that it compiles correctly Tested cassiopeia and atum and the main (only one so far) difference is the colours. You can see this on the typography page in the sample data with cassiopeia Before w/BS5.1After w/BS5.2You can see this easily on the category list page in Atum Before w/BS5.1After w/BS5.2 |
|
i've done some testing, install , front, back etc |
|
I have tested this item ✅ successfully on 339f3d8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39379. |
|
found another color issue in the admin as seen on the hits column before the calculated color was rgb(42, 105, 184) |
|
@brianteeman I manually patched the colour but I left a |
|
ok - i actually had the same problem on my own template last night. took me ages to work out that info-rgb was numbers only |
|
A short explanation for the last few lines added on both templates:
.border-primary {
--border-opacity: 1;
border-color: rgba(var(--primary-rgb), var(--border-opacity)) !important;
}
.border-primary {
border-color:var(--primary-rgb) !important;
}Only side effect is that you cannot change the opacity and somehow affect those values anymore (you couldn't anyway before 5.2!). |
Backend
Frontend (Cassiopeia)
The "Save & Close" button now looks right. It was very different before. Idk what happened. |
|
Both 4.2 and this PR have the same CSS rule here: .table thead {
border-bottom: 2px solid #dee2e6;
}
|
|
I've updated the branch to the latest changes in 4.3-dev. Going to check this again now. Regarding the line: I'm just comparing a default 4.3-dev with your branch it that looks different there. |
|
Ok, it is almost all fixed. 😉 The CSS for kbd-tags is different and seems to be smaller. I could live with that if that is the default of BS. You can see that on the backend dashboard at the bottom with the keyboard shortcuts. Anyway, I'm giving this a thumbs up. |
|
I have tested this item ✅ successfully on a65ecd6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39379. |
|
I have tested this item ✅ successfully on a65ecd6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39379. |
|
I have tested this item ✅ successfully on a65ecd6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39379. |
|
Setting to RTC. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39379. |
|
Thank you so much Dimitris @dgrammatiko for this PR. |
Add deleted files from PRs joomla#39379 , joomla#39539 , joomla#39624 , joomla#39649 and joomla#39625 .






Pull Request for Issue # .
Summary of Changes
Atum
Installation
Cassiopeia
Testing Instructions
Check that all 3 templates (installation/Atum/Cassiopeia) don't have any visual of functional regression
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
For the Bootstrap changes refer to the Bootstrap Docs