Skip to content

Conversation

@dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Dec 8, 2022

Pull Request for Issue # .

Summary of Changes

  • Atum

  • Installation

  • Cassiopeia

Testing Instructions

Check that all 3 templates (installation/Atum/Cassiopeia) don't have any visual of functional regression

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

For the Bootstrap changes refer to the Bootstrap Docs

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.3-dev labels Dec 8, 2022
@dgrammatiko dgrammatiko changed the title [WIP] Upgrade to Bootstrap 5.2 [4.3] Upgrade to Bootstrap 5.2 Dec 8, 2022
@dgrammatiko dgrammatiko marked this pull request as ready for review December 8, 2022 12:36
Co-authored-by: Hannes Papenberg <[email protected]>
@brianteeman
Copy link
Contributor

Tested that it compiles correctly

Tested cassiopeia and atum and the main (only one so far) difference is the colours.

You can see this on the typography page in the sample data with cassiopeia

Before w/BS5.1

image

After w/BS5.2

image

You can see this easily on the category list page in Atum

Before w/BS5.1

image

After w/BS5.2

image

@alikon
Copy link
Contributor

alikon commented Dec 9, 2022

i've done some testing, install , front, back etc
i was unable to discover glitch

@alikon
Copy link
Contributor

alikon commented Dec 9, 2022

I have tested this item ✅ successfully on 339f3d8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39379.

@brianteeman
Copy link
Contributor

found another color issue in the admin as seen on the hits column
badge bg-info calculated color is rgb (13, 202, 240)

before the calculated color was rgb(42, 105, 184)

@dgrammatiko
Copy link
Contributor Author

@brianteeman I manually patched the colour but I left a TODO comment in the variables.scss to investigate why the rgb colour is different (I have a bad flu the last few days so not very easy to do anything meaningful).

@brianteeman
Copy link
Contributor

ok - i actually had the same problem on my own template last night. took me ages to work out that info-rgb was numbers only

@Quy
Copy link
Contributor

Quy commented Dec 13, 2022

39379-install

39379-browse

@dgrammatiko
Copy link
Contributor Author

A short explanation for the last few lines added on both templates:

  • Bootstrap 5.2 is creating an rgb (numerical only) css var for each of the main colours (primary, secondary, info, etc)
  • These values are used from the utilities to create the borders, text color and some background-colors
  • looks like this:
.border-primary {
  --border-opacity: 1;
  border-color: rgba(var(--primary-rgb), var(--border-opacity)) !important;
}
  • since all the opacity values are 1 we can simply use the original var(--primary) instead of building the value at run time, so the previous is the same as:
.border-primary {
  border-color:var(--primary-rgb) !important;
}

Only side effect is that you cannot change the opacity and somehow affect those values anymore (you couldn't anyway before 5.2!).

@Hackwar
Copy link
Member

Hackwar commented Jan 6, 2023

Backend

  • Dashboard: While the lines are now present, the line below the title of the sample data module is too thick, while the line below the table header of the latest action module is not thick enough.
  • On list views (article list view) there is a line above the table header which is missing here and the line below the table header is too thin.

Frontend (Cassiopeia)

  • The header block is now wider than before and menu and title are jumping slightly apart and to the right.

The "Save & Close" button now looks right. It was very different before. Idk what happened.

@dgrammatiko
Copy link
Contributor Author

dgrammatiko commented Jan 6, 2023

the line below the title of the sample data module is too thick Fixed

while the line below the table header of the latest action module is not thick enough.

Both 4.2 and this PR have the same CSS rule here:

.table thead {
    border-bottom: 2px solid #dee2e6;
}

On list views (article list view) there is a line above the table header which is missing here and the line below the table header is too thin. FIXED

The header block is now wider than before and menu and title are jumping slightly apart and to the right. FIXED

@Hackwar
Copy link
Member

Hackwar commented Jan 9, 2023

I've updated the branch to the latest changes in 4.3-dev. Going to check this again now.

Regarding the line: I'm just comparing a default 4.3-dev with your branch it that looks different there.

@Hackwar
Copy link
Member

Hackwar commented Jan 9, 2023

Ok, it is almost all fixed. 😉 The CSS for kbd-tags is different and seems to be smaller. I could live with that if that is the default of BS. You can see that on the backend dashboard at the bottom with the keyboard shortcuts.

Anyway, I'm giving this a thumbs up.

@Hackwar
Copy link
Member

Hackwar commented Jan 9, 2023

I have tested this item ✅ successfully on a65ecd6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39379.

@dgrammatiko
Copy link
Contributor Author

@Hackwar the kbd should be fixed with d93370c

A big thank you for the tests here 👍

@Hackwar
Copy link
Member

Hackwar commented Jan 9, 2023

I have tested this item ✅ successfully on a65ecd6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39379.

@laoneo
Copy link
Member

laoneo commented Jan 9, 2023

I have tested this item ✅ successfully on a65ecd6

Tested it with a couple of extensions like DPCalendar or Akeeba backup


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39379.

@Hackwar Hackwar added the RTC This Pull Request is Ready To Commit label Jan 9, 2023
@Hackwar
Copy link
Member

Hackwar commented Jan 9, 2023

Setting to RTC.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 9, 2023
@Quy
Copy link
Contributor

Quy commented Jan 9, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39379.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 9, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Jan 11, 2023
@obuisard obuisard merged commit 352819a into joomla:4.3-dev Jan 11, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 11, 2023
@obuisard
Copy link
Contributor

Thank you so much Dimitris @dgrammatiko for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants