-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Convert mod_articles_popular to new structure #39539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert mod_articles_popular to new structure #39539
Conversation
|
@chmst I using the wrong branch? |
|
@carlitorweb my apologies, was not intended to remove the label. |
|
I have tested this item ✅ successfully on 130e77b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39539. |
1 similar comment
|
I have tested this item ✅ successfully on 130e77b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39539. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39539. |
modules/mod_articles_popular/src/Helper/ArticlesPopularHelper.php
Outdated
Show resolved
Hide resolved
modules/mod_articles_popular/src/Helper/ArticlesPopularHelper.php
Outdated
Show resolved
Hide resolved
|
I would like to avoid static functions, so I made some suggestions. Can you please review them @carlitorweb ? |
|
@laoneo understood. I will change it for other PRs too. |
Co-authored-by: Allon Moritz <[email protected]>
Co-authored-by: Allon Moritz <[email protected]>
modules/mod_articles_popular/src/Helper/ArticlesPopularHelper.php
Outdated
Show resolved
Hide resolved
|
Can we get here just one more test to ensure the recent cosmetic changes are correct? |
|
thanks |
Add deleted files from PRs joomla#39379 , joomla#39539 , joomla#39624 , joomla#39649 and joomla#39625 .
Summary of Changes
This PR converts mod_articles_popular to the new structure
Testing Instructions