Skip to content

Conversation

@carlitorweb
Copy link
Member

Summary of Changes

This PR converts mod_articles_popular to the new structure

Testing Instructions

  • Use Joomla 4.3
  • Create an instance of the module Articles - Most Read. Note how it works.
  • Apply patch
  • Delete administrator/cache/autoload_psr4.php
  • Refresh the page, make sure the module still displays the same as before.

@carlitorweb
Copy link
Member Author

@chmst I using the wrong branch?

@chmst
Copy link
Contributor

chmst commented Jan 3, 2023

@carlitorweb my apologies, was not intended to remove the label.

@chmst chmst added PR-4.3-dev Maintainers Checked Used if the PR is conceptional useful labels Jan 3, 2023
@chmst
Copy link
Contributor

chmst commented Jan 6, 2023

I have tested this item ✅ successfully on 130e77b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39539.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 130e77b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39539.

@Quy Quy removed the Maintainers Checked Used if the PR is conceptional useful label Jan 9, 2023
@Quy
Copy link
Contributor

Quy commented Jan 9, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39539.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 9, 2023
@laoneo
Copy link
Member

laoneo commented Jan 10, 2023

I would like to avoid static functions, so I made some suggestions. Can you please review them @carlitorweb ?

@carlitorweb
Copy link
Member Author

carlitorweb commented Jan 10, 2023

@laoneo understood. I will change it for other PRs too.

@laoneo
Copy link
Member

laoneo commented Jan 12, 2023

Can we get here just one more test to ensure the recent cosmetic changes are correct?

@HLeithner HLeithner merged commit 8646d15 into joomla:4.3-dev Jan 12, 2023
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 12, 2023
@carlitorweb carlitorweb deleted the convert_mod_articles_popular branch January 12, 2023 17:47
@Quy Quy added this to the Joomla! 4.3.0 milestone Jan 12, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants