-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Converts none editor to service providers #39639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dimitris Grammatikogiannis <[email protected]>
Member
|
@laoneo PHPCS complains: https://ci.joomla.org/joomla/joomla-cms/60911/1/8 |
Member
Author
|
Thanks for the hint, fixed it |
2 tasks
Contributor
|
I have tested this item ✅ successfully on 256c7e8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39639. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 256c7e8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39639. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39639. |
Contributor
|
Thank you Allon @laoneo for the PR :-) |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Converts the none editor to service providers.
This pr contains the commits from #39625.
Testing Instructions
Also test if the other editors do still work
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed