Skip to content

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Jan 15, 2023

Summary of Changes

Converts the none editor to service providers.

This pr contains the commits from #39625.

Testing Instructions

  • Make sure None is the default editor
  • Edit an article

Also test if the other editors do still work

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member

@laoneo
Copy link
Member Author

laoneo commented Jan 15, 2023

Thanks for the hint, fixed it

@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on 256c7e8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39639.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 256c7e8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39639.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39639.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 20, 2023
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Jan 25, 2023
@obuisard obuisard merged commit 7749995 into joomla:4.3-dev Jan 25, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 25, 2023
@obuisard
Copy link
Contributor

Thank you Allon @laoneo for the PR :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants