Skip to content

Mqtt fan command templates#17150

Closed
jbouwh wants to merge 78 commits intohome-assistant:currentfrom
jbouwh:mqtt-fan-command-templates
Closed

Mqtt fan command templates#17150
jbouwh wants to merge 78 commits intohome-assistant:currentfrom
jbouwh:mqtt-fan-command-templates

Conversation

@jbouwh
Copy link
Copy Markdown
Contributor

@jbouwh jbouwh commented Mar 27, 2021 •
edited
Loading

Proposed change

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
  • The documentation follows the Home Assistant documentation standards.

timmo001 and others added 30 commits February 24, 2021 23:29
@timmo001
Update Lyric docs to use config flow include (#16735)
e9ca982
@natekspencer
Adjust wording and add ha_platforms in Litter-Robot documentation (#1…
9694859 
…6737)
@starkillerOG
Add Xiaomi Miio fan config flow (#16683)
c0b7a9b
@hmmbob
Remove docs for removed keyring/credstash options (#16745)
d1294d1
@ludeeus
Fix style for my integration button (#16746)
0e86e8e
@emontnemery
Document value_template in MQTT triggers (#16754)
5e59569
@emontnemery
Fix MQTT trigger value_template example (#16755)
39d3a75
@elupus @klaasnicolaas
Add support for v6 features to philips js integration (#16628)
268f1fb 
Co-authored-by: Klaas Schoute <klaas_schoute@hotmail.com>
@bdraco
Remove griddy integration (#16790)
ca95243
@amelchio
Clarify template trigger behaviour (#16733)
0ad4b12
@frenck
Merge branch 'current' into next
68a3910
@raman325
Update Z-Wave JS limitations for next release (#16796)
0148f5a
@frenck @bramkragten
My plugin updates (#16806)
9efbce2 
Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@frenck
Add more My links (#16816)
f467f49
@frenck
Collection of Markdown/YAML cleanups (#16817)
1a49a1b
@raman325
Update example zwave_js_event value notification event to include new…
9a3fa3d 
… keys (#16815)
@elupus @frenck
Add list of commands (#16807)
53293b6 
Co-authored-by: Franck Nijhof <git@frenck.dev>
@Nick-Adams-AU @frenck
Add airflow min-max service description (#16823)
3aee41e 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@frenck
Merge branch 'current' into next
35e9a00
@frenck
Merge branch 'current' into next
a042c1b
@bdraco
Change default homekit ports to 21063 and 21064 (#16882)
66f7d0c
@frenck
Merge branch 'current' into next
a932d94
@frenck
Deprecate HomeKit auto start (#16874)
2d66a00
@farmio
remove KNX config_file (#16684)
fa0c50f
@Noltari
Add weather support to Tado integration (#16096)
079549f 
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@starkillerOG
Add Xiaomi Miio sensor config flow (#16717)
ee5fa81
@joogps @frenck
Adding Panasonic Viera remote documentation (#15377)
44c4dd6 
Co-authored-by: Franck Nijhof <git@frenck.dev>
@starkillerOG
Add Xiaomi Miio Light config flow (#16782)
40dda04
@starkillerOG
Add subdevice lightbulb support (#16619)
9781bca
@cdce8p
Add apply_filter to recorder.purge service (#16377)
2f3481e
@jbouwh
Copy link
Copy Markdown
Contributor Author

jbouwh commented Mar 29, 2021

This PR adds a new feature to the codebase, thus depends on a next release of Home Assistant Core.

Therefore, this PR should go into the next branch. Please change the target branch of this PR to next and git rebase this PR if needed.

Thanks 👍

I am not sure. The PR for code change is targeted to current, not to next, I have changed this later in this documention PR.

@chemaaa @klaasnicolaas @frenck
Add Legrand Home+ Control Integration document (#16644)
b304c0f 
Co-authored-by: Klaas Schoute <klaas_schoute@hotmail.com>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 29, 2021

I am sure, this targets the wrong branch. Please adjust as instructed in my last response.

@jbouwh
Copy link
Copy Markdown
Contributor Author

jbouwh commented Mar 29, 2021

I think I need some help, I messed up this PR in order to target it it right.

@frenck frenck changed the base branch from current to next March 29, 2021 11:19
@frenck frenck changed the base branch from next to current March 29, 2021 11:19
@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 29, 2021

It seems like you have been merging branches, instead of rebasing. At this point, either strip of the merge and do a rebase after that or hard reset the branch and cherry-pick your changes.

Alternatively, creating a new PR based from the next branch is an option as well.

@jbouwh
Copy link
Copy Markdown
Contributor Author

jbouwh commented Mar 29, 2021

I will start a new PR for this.

@jbouwh jbouwh closed this Mar 29, 2021
@probot-home-assistant probot-home-assistant Bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Mar 29, 2021
@jbouwh jbouwh deleted the mqtt-fan-command-templates branch March 29, 2021 15:06
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@frenck frenck frenck requested changes

Assignees

@jbouwh jbouwh

Labels

cla-signed current This PR goes into the current branch has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.