Skip to content

Add apply_filter to recorder.purge service#16377

Merged
frenck merged 2 commits intohome-assistant:nextfrom
cdce8p:recorder-apply_filter
Mar 15, 2021
Merged

Add apply_filter to recorder.purge service#16377
frenck merged 2 commits intohome-assistant:nextfrom
cdce8p:recorder-apply_filter

Conversation

@cdce8p
Copy link
Copy Markdown
Member

@cdce8p cdce8p commented Feb 1, 2021

Proposed change

Add apply_filter attribute to recorder.purge service.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added the has-parent This PR has a parent PR in another repo label Feb 1, 2021
@probot-home-assistant probot-home-assistant Bot added the next This PR goes into the next branch label Feb 1, 2021
@frenck frenck added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Feb 2, 2021
frenck
frenck previously approved these changes Feb 2, 2021
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Feb 2, 2021
@frenck frenck added the parent-merged The parent PR has been merged already label Mar 12, 2021
@cdce8p cdce8p removed the awaits-parent Awaits the merge of an parent PR label Mar 12, 2021
@cdce8p
Copy link
Copy Markdown
Member Author

cdce8p commented Mar 12, 2021

This PR is ready for review and merge. Just needed to do a small last minute update. Not quite sure though, why the build isn't passing. Seems like a dependency issue.

@cdce8p
Copy link
Copy Markdown
Member Author

cdce8p commented Mar 13, 2021

@frenck Can you merge current into next again? The CI issue is likely related to #16929

@cdce8p
Copy link
Copy Markdown
Member Author

cdce8p commented Mar 15, 2021

@bdraco Would you mind taking a quick look at this? It's the documentation for the apply_filter feature. home-assistant/core#45826

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cdce8p 👍

@frenck frenck merged commit 2f3481e into home-assistant:next Mar 15, 2021
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Mar 15, 2021
@cdce8p cdce8p deleted the recorder-apply_filter branch March 15, 2021 14:42
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants