Add apply_filter to recorder.purge service#16377
Merged
frenck merged 2 commits intohome-assistant:nextfrom Mar 15, 2021
cdce8p:recorder-apply_filter
Merged
Add apply_filter to recorder.purge service#16377frenck merged 2 commits intohome-assistant:nextfrom cdce8p:recorder-apply_filter
frenck merged 2 commits intohome-assistant:nextfrom
cdce8p:recorder-apply_filter
Conversation
21 tasks
frenck
previously approved these changes
Feb 2, 2021
Member
frenck
left a comment
There was a problem hiding this comment.
✅ Approved. Can be merged as soon as the parent PR gets merged.
Member
Author
|
This PR is ready for review and merge. Just needed to do a small last minute update. Not quite sure though, why the build isn't passing. Seems like a dependency issue. |
Member
Author
Member
Author
|
@bdraco Would you mind taking a quick look at this? It's the documentation for the |
frenck
approved these changes
Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Add
apply_filterattribute torecorder.purgeservice.Type of change
currentbranch).currentbranch).nextbranch).nextbranch).Additional information
Checklist
currentbranch.nextbranch.