Command template support for MQTT fan#48413
Merged
emontnemery merged 4 commits intohome-assistant:devfrom Mar 29, 2021
Merged
Conversation
|
Hey there @emontnemery, mind taking a look at this pull request as its been labeled with an integration ( |
Contributor
Author
|
This would enable to use e.g. tuya fans with the generic mqtt fan. |
8 tasks
Contributor
Author
|
Some how de documentation changes (supporting command templates) already merged into current for this PR. I have been closing this PR (home-assistant/home-assistant.io#17150) |
emontnemery
reviewed
Mar 29, 2021
Contributor
emontnemery
left a comment
There was a problem hiding this comment.
Looks good, just one comment.
Co-authored-by: Erik Montnemery <erik@montnemery.com>
8 tasks
Contributor
Author
|
Document PR was changed to home-assistant/home-assistant.io#17173 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
The fan entitity model was changed introducing preset_modes and percentage to replace the legacy model supporting only three speeds
low,mediumandhigh.PR #47944 implements this, but with leaving the legacy speeds will not be possible to use custom payload on speeds any more. This PR solves this by introducing command templates for state, oscillation, preset_mode and percentage.
Proposed change
Introduce command templates for all command topics. This enable the ability to customize outgoing payload for state, oscillation, preset_mode and percentage command topics.
command_topic.oscillation_command_topic.percentage_command_topic.preset_mode_command_topic.Type of change
Example entry for
configuration.yaml:Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: