Skip to content

Remove docs for removed keyring/credstash options#16745

Merged
frenck merged 6 commits into
home-assistant:nextfrom
hmmbob:patch-1
Feb 25, 2021
Merged

Remove docs for removed keyring/credstash options#16745
frenck merged 6 commits into
home-assistant:nextfrom
hmmbob:patch-1

Conversation

@hmmbob
Copy link
Copy Markdown
Contributor

@hmmbob hmmbob commented Feb 25, 2021

Proposed change

Remove docs for removed keyring/credstash options.

The methods of storing secrets in credstash and keyring have been removed. They have been deprecated and a warning has been printed since Home Assistant 2020.12. Support is removed in 2021.3.0

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Feb 25, 2021
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also shown in the aside bar as links, that need to be cleaned up. Additionally, add a redirect to removed integrations for these paths in the _redirects file, so people don't land on a 404 following an old link.

@frenck frenck added cleanup in-progress This PR/Issue is currently being worked on labels Feb 25, 2021
@hmmbob
Copy link
Copy Markdown
Contributor Author

hmmbob commented Feb 25, 2021

Good catch. Did a search for credstash and keyring on my forked repo through the github site but nothing had popped up. Searching for it on the main repo shows them as expected. Found a leftover as well.

I redirected the two pages to the secrets page, as that looked more like what we did with other doc redirects and it is the alternative to the deprecated functionality. Let me know if this is ok, or if it should redirect to removed integration regardless.

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hmmbob 👍

@frenck frenck merged commit d1294d1 into home-assistant:next Feb 25, 2021
@probot-home-assistant probot-home-assistant Bot removed the in-progress This PR/Issue is currently being worked on label Feb 25, 2021
@hmmbob hmmbob deleted the patch-1 branch February 25, 2021 12:45
@balloob balloob added this to the 2021.3.0 milestone Feb 25, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 26, 2021
@frenck frenck added the cherry-picked This PR has been manually picked and merged into the current branch label Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked This PR has been manually picked and merged into the current branch cla-signed cleanup has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants