Reolink add new number entities by starkillerOG · Pull Request #87932 · home-assistant/core

starkillerOG · 2023-02-12T13:53:45Z

Breaking change

Proposed change

Add Reolink control for:

floodlight brightness
volume
guard return time
motion sensitivity
AI sensitivity for
- Face detection
- People detection
- Vehicle detection
- Pet detection

Completing all reolink features with these PRs:

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: Add new Reolink number entities home-assistant.io#26283

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2023-02-12T19:03:17Z

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

starkillerOG · 2023-02-13T11:17:37Z

Floodlight brightness is going to be implemented as a light entity instead.
Once I made that PR, I will clean this PR to only have the small typing fixes etc.

~~First we need to decide how to implement the floodlight, see discussion here: #87943~~

~~Version bump to Reolink-aio 0.5.0 required, see PR #88594.~~

starkillerOG · 2023-02-22T23:58:49Z

@frenck I have adressed all changes you requested, could you do another review?

Co-authored-by: Franck Nijhof <frenck@frenck.nl>

frenck

LGTM, thanks @starkillerOG 👍

../Frenck

MartinHjelmare · 2023-03-06T13:36:37Z

+    ReolinkNumberEntityDescription(
+        key="floodlight_brightness",
+        name="Floodlight turn on brightness",
+        icon="mdi:spotlight-beam",
+        entity_category=EntityCategory.CONFIG,
+        native_step=1,
+        native_min_value=1,
+        native_max_value=100,
+        supported=lambda api, ch: api.supported(ch, "floodLight"),
+        value=lambda api, ch: api.whiteled_brightness(ch),
+        method=lambda api, ch, value: api.set_whiteled(ch, brightness=int(value)),
+    ),


What's the difference between this number entity and the light entity for the floodlight?

core/homeassistant/components/reolink/light.py

Lines 46 to 55 in 0c042e8

ReolinkLightEntityDescription(

key="floodlight",

name="Floodlight",

icon="mdi:spotlight-beam",

supported_fn=lambda api, ch: api.supported(ch, "floodLight"),

is_on_fn=lambda api, ch: api.whiteled_state(ch),

turn_on_off_fn=lambda api, ch, value: api.set_whiteled(ch, state=value),

get_brightness_fn=lambda api, ch: api.whiteled_brightness(ch),

set_brightness_fn=lambda api, ch, value: api.set_whiteled(ch, brightness=value),

),

See discussion above: #87932 (review)

I read up on the comment history in the PR.

Please add a code comment explaining the situation so we don't need to wonder what's going on when reading the code.

👍
CC @starkillerOG

I will add a code comment and some extra documentation because this is indeed not clear enough, just a moment

Documentation PR is here: home-assistant/home-assistant.io#26469

Code comment PR is here: #89234

starkillerOG added 2 commits February 12, 2023 14:42

Add floodlight brightness

752a7ef

Request refresh when setting value

3cbeb10

home-assistant Bot added cla-signed integration: reolink new-feature small-pr PRs with less than 30 lines. by-code-owner Quality Scale: No score labels Feb 12, 2023

starkillerOG added 3 commits February 12, 2023 15:06

fix type

cd0e54c

No need to fetch state

1d2f6b2

Merge branch 'dev' into reolink_floodlight_bright

99a7ffe

starkillerOG mentioned this pull request Feb 12, 2023

Reolink add new features home-assistant/home-assistant.io#26224

Closed

8 tasks

frenck requested changes Feb 12, 2023

View reviewed changes

Comment thread homeassistant/components/reolink/number.py Outdated

home-assistant Bot marked this pull request as draft February 12, 2023 19:03

NumberMode not needed

09215aa

starkillerOG marked this pull request as ready for review February 13, 2023 09:33

home-assistant Bot requested a review from frenck February 13, 2023 09:33

starkillerOG marked this pull request as draft February 13, 2023 11:16

starkillerOG mentioned this pull request Feb 13, 2023

Reolink add switch platform #87943

Merged

19 tasks

Add volume control

ddd2ac4

starkillerOG changed the title ~~Reolink add floodlight brightness~~ Reolink add floodlight brightness and volume control Feb 17, 2023

starkillerOG mentioned this pull request Feb 17, 2023

Add new Reolink number entities home-assistant/home-assistant.io#26283

Merged

8 tasks

starkillerOG added 2 commits February 17, 2023 11:11

Merge branch 'dev' into reolink_floodlight_bright

6099990

Merge branch 'dev' into reolink_floodlight_bright

0486a5a

starkillerOG marked this pull request as ready for review February 22, 2023 17:36

Add aditional number entities

3dfcbb3

starkillerOG changed the title ~~Reolink add floodlight brightness and volume control~~ Reolink add new number entities Feb 22, 2023

This was referenced Feb 24, 2023

Add Reolink button platform #88687

Merged

Reolink add select platform #87946

Merged

Add Reolink siren platform #88217

Merged

Add Reolink light platform #88619

Merged

Reolink integration working, then offline for a day.. #87511

Closed

starkillerOG mentioned this pull request Mar 3, 2023

(Feature Request) Need switches to enable/disable email alerts and FTP uploads starkillerOG/reolink_aio#7

Closed

require channel

c49e386

cgarwood reviewed Mar 3, 2023

View reviewed changes

Comment thread homeassistant/components/reolink/number.py Outdated

starkillerOG mentioned this pull request Mar 3, 2023

Reolink check firmware #88903

Merged

19 tasks

starkillerOG added 2 commits March 4, 2023 23:52

Add EntityCategory

94728e9

Merge branch 'dev' into reolink_floodlight_bright

543ed96

frenck requested changes Mar 6, 2023

View reviewed changes

home-assistant Bot marked this pull request as draft March 6, 2023 08:57

starkillerOG and others added 3 commits March 6, 2023 10:05

Apply suggestions from code review

4b6b589

Co-authored-by: Franck Nijhof <frenck@frenck.nl>

Use native_min/max_value when no lambda required

a7ceedd

fix black

2ba9039

starkillerOG marked this pull request as ready for review March 6, 2023 09:16

home-assistant Bot requested a review from frenck March 6, 2023 09:16

starkillerOG added 2 commits March 6, 2023 10:17

Rename to "Floodlight turn on brightness"

b4416d0

Merge branch 'dev' into reolink_floodlight_bright

d9cf556

frenck approved these changes Mar 6, 2023

View reviewed changes

frenck merged commit b2166c3 into home-assistant:dev Mar 6, 2023

MartinHjelmare reviewed Mar 6, 2023

View reviewed changes

This was referenced Mar 6, 2023

Add clarification for reolink entities home-assistant/home-assistant.io#26469

Merged

Add comment about Reolink Floodlight turn on brightness #89234

Merged

github-actions Bot locked and limited conversation to collaborators Mar 7, 2023

frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Mar 28, 2023

	ReolinkLightEntityDescription(
	key="floodlight",
	name="Floodlight",
	icon="mdi:spotlight-beam",
	supported_fn=lambda api, ch: api.supported(ch, "floodLight"),
	is_on_fn=lambda api, ch: api.whiteled_state(ch),
	turn_on_off_fn=lambda api, ch, value: api.set_whiteled(ch, state=value),
	get_brightness_fn=lambda api, ch: api.whiteled_brightness(ch),
	set_brightness_fn=lambda api, ch, value: api.set_whiteled(ch, brightness=value),
	),

Uh oh!

Conversation

starkillerOG commented Feb 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking change

Proposed change

Type of change

Additional information

Checklist

Uh oh!

Uh oh!

home-assistant Bot commented Feb 12, 2023

Uh oh!

starkillerOG commented Feb 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

starkillerOG commented Feb 22, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

frenck left a comment

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare Mar 6, 2023

Choose a reason for hiding this comment

Uh oh!

frenck Mar 6, 2023

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare Mar 6, 2023

Choose a reason for hiding this comment

Uh oh!

frenck Mar 6, 2023

Choose a reason for hiding this comment

Uh oh!

starkillerOG Mar 6, 2023

Choose a reason for hiding this comment

Uh oh!

starkillerOG Mar 6, 2023

Choose a reason for hiding this comment

Uh oh!

starkillerOG Mar 6, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

starkillerOG commented Feb 12, 2023 •

edited

Loading

starkillerOG commented Feb 13, 2023 •

edited

Loading