Skip to content

Reolink add switch platform#87943

Merged
frenck merged 19 commits into
home-assistant:devfrom
starkillerOG:reolink_switch2
Mar 5, 2023
Merged

Reolink add switch platform#87943
frenck merged 19 commits into
home-assistant:devfrom
starkillerOG:reolink_switch2

Conversation

@starkillerOG
Copy link
Copy Markdown
Contributor

@starkillerOG starkillerOG commented Feb 12, 2023

Breaking change

Proposed change

Add reolink camera switch entities for:

  • Record audio
  • Siren on event
  • Auto tracking
  • Auto focus
  • Guard return

Add reolink host/NVR switch entities for:

  • Email on event
  • FTP upload
  • Push notifications
  • Record
  • Buzzer on event

Completing all reolink features with these PRs:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Comment thread homeassistant/components/reolink/switch.py
Comment thread homeassistant/components/reolink/switch.py
@home-assistant home-assistant Bot marked this pull request as draft February 12, 2023 21:21
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@starkillerOG starkillerOG mentioned this pull request Feb 13, 2023
19 tasks
@starkillerOG starkillerOG marked this pull request as ready for review February 13, 2023 12:13
@home-assistant home-assistant Bot requested a review from frenck February 13, 2023 12:13
@starkillerOG
Copy link
Copy Markdown
Contributor Author

@frenck could you help me with deciding which features schould be which entities?
Once I know, I can proceed with the required adjustments.

@starkillerOG
Copy link
Copy Markdown
Contributor Author

@frenck I have adressed all changes you requested, could you do another review?

Copy link
Copy Markdown
Member

@cgarwood cgarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@starkillerOG starkillerOG mentioned this pull request Mar 3, 2023
19 tasks
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks, @starkillerOG 👍

@frenck frenck merged commit b2c9208 into home-assistant:dev Mar 5, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 6, 2023
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Mar 28, 2023
@starkillerOG starkillerOG deleted the reolink_switch2 branch October 2, 2025 08:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

by-code-owner cla-signed integration: reolink new-feature new-platform noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: No score

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants