Add Reolink light platform#88619
Merged
Merged
Conversation
This was referenced Feb 22, 2023
joncar
reviewed
Feb 23, 2023
This was referenced Feb 24, 2023
joncar
approved these changes
Feb 24, 2023
Kane610
reviewed
Feb 25, 2023
Member
Kane610
left a comment
Kane610
left a comment
There was a problem hiding this comment.
Looks really good, some minor comments to consider.
Contributor
Author
|
@Kane610 thanks for the review, I have processed your feedback, could you have another look? |
Kane610
reviewed
Mar 1, 2023
Contributor
Author
|
@Kane610 thanks for the additional feedback! |
Member
I'll have a look tonight. But I don't think so. |
Contributor
Author
|
@Kane610 Thank you for approving this PR! |
frenck
requested changes
Mar 4, 2023
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
frenck
approved these changes
Mar 6, 2023
Member
frenck
left a comment
frenck
left a comment
There was a problem hiding this comment.
LGTM, thanks @starkillerOG 👍
../Frenck
frenck
added
the
noteworthy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Add reolink light entities for:
Completing all reolink features with these PRs:
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: