Skip to content

Reolink add new number entities #87932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 18 commits into from
Mar 6, 2023
Merged

Reolink add new number entities #87932

Changes from 5 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
752a7ef
Add floodlight brightness
starkillerOG Feb 12, 2023
3cbeb10
Request refresh when setting value
starkillerOG Feb 12, 2023
cd0e54c
fix type
starkillerOG Feb 12, 2023
1d2f6b2
No need to fetch state
starkillerOG Feb 12, 2023
99a7ffe
Merge branch 'dev' into reolink_floodlight_bright
starkillerOG Feb 12, 2023
09215aa
NumberMode not needed
starkillerOG Feb 13, 2023
ddd2ac4
Add volume control
starkillerOG Feb 17, 2023
6099990
Merge branch 'dev' into reolink_floodlight_bright
starkillerOG Feb 17, 2023
0486a5a
Merge branch 'dev' into reolink_floodlight_bright
starkillerOG Feb 22, 2023
3dfcbb3
Add aditional number entities
starkillerOG Feb 22, 2023
c49e386
require channel
starkillerOG Mar 3, 2023
94728e9
Add EntityCategory
starkillerOG Mar 4, 2023
543ed96
Merge branch 'dev' into reolink_floodlight_bright
starkillerOG Mar 5, 2023
4b6b589
Apply suggestions from code review
starkillerOG Mar 6, 2023
a7ceedd
Use native_min/max_value when no lambda required
starkillerOG Mar 6, 2023
2ba9039
fix black
starkillerOG Mar 6, 2023
b4416d0
Rename to "Floodlight turn on brightness"
starkillerOG Mar 6, 2023
d9cf556
Merge branch 'dev' into reolink_floodlight_bright
starkillerOG Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions homeassistant/components/reolink/number.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
class ReolinkNumberEntityDescriptionMixin:
"""Mixin values for Reolink number entities."""

value: Callable[[Host, int | None], bool]
value: Callable[[Host, int | None], float]
get_min_value: Callable[[Host, int | None], float]
get_max_value: Callable[[Host, int | None], float]
method: Callable[[Host, int | None, float], Any]
Expand All @@ -50,7 +50,7 @@ class ReolinkNumberEntityDescription(
native_step=1,
get_min_value=lambda api, ch: api.zoom_range(ch)["zoom"]["pos"]["min"],
get_max_value=lambda api, ch: api.zoom_range(ch)["zoom"]["pos"]["max"],
supported=lambda api, ch: api.zoom_supported(ch),
supported=lambda api, ch: api.supported(ch, "zoom"),
value=lambda api, ch: api.get_zoom(ch),
method=lambda api, ch, value: api.set_zoom(ch, int(value)),
),
Expand All @@ -62,10 +62,22 @@ class ReolinkNumberEntityDescription(
native_step=1,
get_min_value=lambda api, ch: api.zoom_range(ch)["focus"]["pos"]["min"],
get_max_value=lambda api, ch: api.zoom_range(ch)["focus"]["pos"]["max"],
supported=lambda api, ch: api.zoom_supported(ch),
supported=lambda api, ch: api.supported(ch, "zoom"),
value=lambda api, ch: api.get_focus(ch),
method=lambda api, ch, value: api.set_zoom(ch, int(value)),
),
ReolinkNumberEntityDescription(
key="floodlight_brightness",
name="Floodlight brightness",
Comment thread
frenck marked this conversation as resolved.
Outdated
icon="mdi:spotlight-beam",
mode=NumberMode.SLIDER,
Comment thread
frenck marked this conversation as resolved.
Outdated
native_step=1,
get_min_value=lambda api, ch: 1,
get_max_value=lambda api, ch: 100,
Comment thread
starkillerOG marked this conversation as resolved.
Outdated
supported=lambda api, ch: api.supported(ch, "floodLight"),
value=lambda api, ch: api.whiteled_brightness(ch),
method=lambda api, ch, value: api.set_whiteled(ch, brightness=int(value)),
),
Comment on lines +70 to +81

@MartinHjelmare MartinHjelmare Mar 6, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between this number entity and the light entity for the floodlight?

core/homeassistant/components/reolink/light.py

Lines 46 to 55 in 0c042e8

ReolinkLightEntityDescription(
key="floodlight",
name="Floodlight",
icon="mdi:spotlight-beam",
supported_fn=lambda api, ch: api.supported(ch, "floodLight"),
is_on_fn=lambda api, ch: api.whiteled_state(ch),
turn_on_off_fn=lambda api, ch, value: api.set_whiteled(ch, state=value),
get_brightness_fn=lambda api, ch: api.whiteled_brightness(ch),
set_brightness_fn=lambda api, ch, value: api.set_whiteled(ch, brightness=value),
),

@frenck frenck Mar 6, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussion above: #87932 (review)

@MartinHjelmare MartinHjelmare Mar 6, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read up on the comment history in the PR.

Please add a code comment explaining the situation so we don't need to wonder what's going on when reading the code.

@frenck frenck Mar 6, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
CC @starkillerOG

@starkillerOG starkillerOG Mar 6, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add a code comment and some extra documentation because this is indeed not clear enough, just a moment

@starkillerOG starkillerOG Mar 6, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation PR is here: home-assistant/home-assistant.io#26469

@starkillerOG starkillerOG Mar 6, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code comment PR is here: #89234

)


Expand Down Expand Up @@ -120,3 +132,4 @@ def native_value(self) -> float:
async def async_set_native_value(self, value: float) -> None:
"""Update the current value."""
await self.entity_description.method(self._host.api, self._channel, value)
self.async_write_ha_state()