Skip to content

Reolink check firmware#88903

Merged
frenck merged 13 commits into
home-assistant:devfrom
starkillerOG:reolink_check_firmware
Mar 15, 2023
Merged

Reolink check firmware#88903
frenck merged 13 commits into
home-assistant:devfrom
starkillerOG:reolink_check_firmware

Conversation

@starkillerOG
Copy link
Copy Markdown
Contributor

@starkillerOG starkillerOG commented Feb 28, 2023

Breaking change

Proposed change

Raise a repair issue when the firmware version of the camera/NVR is lower than the minimum firmware version known to work with the HomeAssistant reolink integration, and provide instructions on how to update the firmware.

This is needed because the "check for firmware update" in the reolink app/client/webclient/API does not always correctly provide the latest available firmware, but tells the users it is up to date while it is in fact not.

Reolink_firmware_issue_1
Reolink_firmware_issue_2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

epenet
epenet previously requested changes Feb 28, 2023
Comment thread tests/components/reolink/test_config_flow.py Outdated
@home-assistant home-assistant Bot marked this pull request as draft February 28, 2023 22:55
@home-assistant
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@starkillerOG
Copy link
Copy Markdown
Contributor Author

@epenet I will make a seperate PR to clean up the tests and fully cover init.py

Would you be willing to also review the open PRs for new reolink features:

@starkillerOG starkillerOG mentioned this pull request Mar 3, 2023
19 tasks
@starkillerOG starkillerOG requested a review from epenet March 3, 2023 16:52
@starkillerOG starkillerOG marked this pull request as ready for review March 8, 2023 09:02
@epenet epenet dismissed their stale review March 8, 2023 09:02

Stale - comment has been addressed.

@epenet epenet removed the dependency Pull requests marked as a dependency upgrade label Mar 8, 2023
@starkillerOG
Copy link
Copy Markdown
Contributor Author

@epenet thank you for the initial review, do you have any more feedback?

@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 14, 2023

@starkillerOG I admire your work, but I have now warned you about pinging for reviews a couple of times. I do not continue warning about it again. Consider this a final and last warning.

Thanks 👍

../Frenck

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 14, 2023
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @starkillerOG 👍

../Frenck

@frenck frenck merged commit 4eee626 into home-assistant:dev Mar 15, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix by-code-owner cla-signed has-tests integration: reolink Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants