Reolink check firmware#88903
Merged
Merged
Conversation
epenet
previously requested changes
Feb 28, 2023
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Contributor
Author
|
@epenet I will make a seperate PR to clean up the tests and fully cover init.py Would you be willing to also review the open PRs for new reolink features: |
Contributor
Author
|
@epenet thank you for the initial review, do you have any more feedback? |
Member
|
@starkillerOG I admire your work, but I have now warned you about pinging for reviews a couple of times. I do not continue warning about it again. Consider this a final and last warning. Thanks 👍 ../Frenck |
frenck
approved these changes
Mar 15, 2023
Member
frenck
left a comment
There was a problem hiding this comment.
Looks good, thanks @starkillerOG 👍
../Frenck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Raise a repair issue when the firmware version of the camera/NVR is lower than the minimum firmware version known to work with the HomeAssistant reolink integration, and provide instructions on how to update the firmware.
This is needed because the "check for firmware update" in the reolink app/client/webclient/API does not always correctly provide the latest available firmware, but tells the users it is up to date while it is in fact not.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: