Skip to content

Add clarification for reolink entities#26469

Merged
frenck merged 7 commits into
home-assistant:nextfrom
starkillerOG:patch-103
Mar 6, 2023
Merged

Add clarification for reolink entities#26469
frenck merged 7 commits into
home-assistant:nextfrom
starkillerOG:patch-103

Conversation

@starkillerOG
Copy link
Copy Markdown
Contributor

Proposed change

Add clarification for reolink entities

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Mar 6, 2023
@starkillerOG
Copy link
Copy Markdown
Contributor Author

@frenck can you merge this?
(It is about the core PRs you merged).

@frenck
Copy link
Copy Markdown
Member

frenck commented Mar 6, 2023

@starkillerOG Can you please stop mentioning and pulling people into PRs?

https://developers.home-assistant.io/docs/review-process#what-not-to-do

Comment thread source/_integrations/reolink.markdown Outdated
Comment thread source/_integrations/reolink.markdown Outdated
Comment thread source/_integrations/reolink.markdown Outdated
Comment thread source/_integrations/reolink.markdown Outdated
Comment thread source/_integrations/reolink.markdown Outdated
@home-assistant home-assistant Bot marked this pull request as draft March 6, 2023 15:11
@home-assistant
Copy link
Copy Markdown

home-assistant Bot commented Mar 6, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

starkillerOG and others added 5 commits March 6, 2023 16:27
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@starkillerOG starkillerOG marked this pull request as ready for review March 6, 2023 17:27
@home-assistant home-assistant Bot requested a review from frenck March 6, 2023 17:28
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @starkillerOG 👍

../Frenck

@frenck frenck merged commit 69c01f5 into home-assistant:next Mar 6, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants