Reolink add select platform#87946
Conversation
frenck
left a comment
There was a problem hiding this comment.
I would expect translations to be provided for the items in the select entities, yet they seem not to be in this PR. Is that intentional?
../Frenck
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
@frenck thanks for making me aware of the select translations, had not done that before so was not aware that was needed. I have now added the required translations. |
Those are not required, but we should add them to improve the experience. The translations capabilities are extensively documented here: https://developers.home-assistant.io/docs/internationalization/core |
|
@frenck I have adressed all changes you requested, could you do another review? |
|
@Kane610 thanks for the review, I have made some adjustments. |
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
|
@frenck thank you very much for your reviews (also for the other reolink feature PRs)! |
frenck
left a comment
There was a problem hiding this comment.
Thanks, @starkillerOG 👍
../Frenck
Breaking change
Proposed change
Add Reolink select entities for:
Completing all reolink features with these PRs:
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: