Inverted rflink cover

[fmartens]

Breaking Change:

The configuration has to be updated when KAKU (newkaku) ASUN-650 covers are used. The 'type' property has to be specified and set to 'standard' when these devices have been wired 'the other way around'.

Description:

A class named InvertedRflinkCover has been added that inverts the commands to the KAKU (COCO) ASUN-650 devices. Also a property named 'type' has been added to the RflinkCover class that allows 2 values: 'standard' and 'inverted'. The InvertedRflinkCover class is used when:

• The RflinkCover class detects 'newkaku' device and the type property is omitted.
• The type property is set to 'inverted'.

Related issue (if applicable): fixes #10810

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10177

Example entry for configuration.yaml (if applicable):

cover rflink:
  - platform: rflink
    devices:
      newkaku_xxxxxxxx_x:
        name: kaku_inverted_by_type
        type: inverted
      newkaku_xxxxxxxx_y:
        name: kaku_not_inverted_by_type
        type: standard
      newkaku_xxxxxxxx_z:
        name: kaku_inverted_by_default
      nonkaku_yyyyyyyy_x:
        name: non_kaku_inverted_by_type
        type: inverted
      nonkaku_yyyyyyyy_y:
        name: non_kaku_not_inverted_by_type
        type: standard
      nonkaku_yyyyyyyy_z:
        name: non_kaku_not_inverted_by_default

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[fmartens]

I can't figure out yet why CI (Tests PyTest Python36) and CI (FullCheck Pylint) are failing.

[javicalle]

Seems related with some merged code from dev branch:
tests/components/updater/test_init.py:151

[fmartens]

@javicalle , are my tests failing because of #26187?

I also noticed that the Pylint test fails when setting up the environment.

ERROR: Could not find a version that satisfies the requirement bimmer_connected==0.5.6 (from -r requirements_all.txt (line 269)) (from versions: 0.0.1, 0.0.3, 0.0.4, 0.1.0, 0.2.0, 0.3.0, 0.4.0.dev0, 0.4.0, 0.4.1, 0.5.0, 0.5.1, 0.5.2, 0.5.3, 0.5.9b0, 0.5.9b1)
ERROR: No matching distribution found for bimmer_connected==0.5.6 (from -r requirements_all.txt (line 269)))

Is this something I can/should fix or should I commit a change to trigger the tests again?

[javicalle]

Also may be related with some code merged from dev branch. What I would try is to review the 'files' that fail, see if there are changes in the dev branch, make the merge only of those changes and commit from my branch to force the execution of the tests. I'm sorry not being able to help more. El dom., 25 ago. 2019 14:25, fmartens <notifications@github.com> escribió:

…

@javicalle <https://github.com/javicalle> , are my tests failing because of #26187 <#26187>? I also noticed that the Pylint test fails when setting up the environment. ERROR: Could not find a version that satisfies the requirement bimmer_connected==0.5.6 (from -r requirements_all.txt (line 269)) (from versions: 0.0.1, 0.0.3, 0.0.4, 0.1.0, 0.2.0, 0.3.0, 0.4.0.dev0, 0.4.0, 0.4.1, 0.5.0, 0.5.1, 0.5.2, 0.5.3, 0.5.9b0, 0.5.9b1) ERROR: No matching distribution found for bimmer_connected==0.5.6 (from -r requirements_all.txt (line 269))) Is this something I can/should fix or should I commit a change to trigger the tests again? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#26038>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHUEP7MHGMYLAE2WMZTLFHDQGJ22HANCNFSM4IMRS4XQ> .

[MartinHjelmare]

Looks good!

[fmartens]

@javicalle , thanks for all the support.