Fix race during initial Sonos group construction#26371
Merged
Merged
Conversation
probot-home-assistant
Bot
added
integration: sonos
small-pr
pvizeli
reviewed
Sep 3, 2019
MartinHjelmare
requested changes
Sep 3, 2019
amelchio
commented
Sep 3, 2019
MartinHjelmare
approved these changes
Sep 3, 2019
balloob
pushed a commit
that referenced
this pull request
Sep 4, 2019
* Fix race during initial Sonos group construction * Update homeassistant/components/sonos/media_player.py
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When adding a player we must rebuild all groups because the new player could be part of an existing group. This change moves the rebuilding of groups to after an entity has been appended to our local inventory.
This avoids 2+ players rebuilding groups with each not yet knowing about the other.
Related issue (if applicable): fixes #26326
Checklist:
tox. Your PR cannot be merged unless tests pass