Skip to content

Change evohome to asyncio client#26042

Merged
zxdavb merged 21 commits into
home-assistant:devfrom
zxdavb:async_evohome
Sep 1, 2019
Merged

Change evohome to asyncio client#26042
zxdavb merged 21 commits into
home-assistant:devfrom
zxdavb:async_evohome

Conversation

@zxdavb
Copy link
Copy Markdown
Member

@zxdavb zxdavb commented Aug 18, 2019

Breaking Change:

None known.

Description:

Uses evohome-async instead of evohome-client, and thus switches from requests to aiohttp.

Addresses issue #25400, and adds code to handle devices with flat batteries.

Some minor de-linting.

Related issue (if applicable): fixes #25400

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@zxdavb zxdavb requested a review from MartinHjelmare August 18, 2019 10:21
@zxdavb zxdavb changed the title Change evohome to asyncio Change evohome to asyncio client Aug 18, 2019
@zxdavb zxdavb marked this pull request as ready for review August 18, 2019 11:18
@zxdavb
Copy link
Copy Markdown
Member Author

zxdavb commented Aug 28, 2019

@MartinHjelmare Could you look at this for me?

I have ported the client library (with the original repo's owner's blessing) over to async - now the component is fully async.

@zxdavb zxdavb requested a review from balloob August 31, 2019 20:10
Comment thread homeassistant/components/evohome/__init__.py Outdated
Comment thread homeassistant/components/evohome/__init__.py Outdated
Comment thread homeassistant/components/evohome/__init__.py Outdated
Comment thread homeassistant/components/evohome/climate.py Outdated
Comment thread homeassistant/components/evohome/climate.py
Comment thread homeassistant/components/evohome/water_heater.py
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zxdavb
Copy link
Copy Markdown
Member Author

zxdavb commented Sep 1, 2019

Looks good!

OK to merge? - Oh, I see: Approved!

@zxdavb zxdavb merged commit f91dd4f into home-assistant:dev Sep 1, 2019
@zxdavb zxdavb deleted the async_evohome branch September 1, 2019 10:45
@zxdavb
Copy link
Copy Markdown
Member Author

zxdavb commented Sep 1, 2019

Thanks @MartinHjelmare !

pgilad added a commit to pgilad/home-assistant that referenced this pull request Sep 1, 2019
…into improve-bluetooth-tracker

* 'dev' of https://github.com/home-assistant/home-assistant: (229 commits)
  New template sensor attributes (home-assistant#26127)
  Add BeeWi SmartClim BLE sensors (home-assistant#26174)
  UniFi - Simplify getting controller from config entry (home-assistant#26335)
  Inverted rflink cover (home-assistant#26038)
  Upgrade tibber library (home-assistant#26332)
  Migrate Axis, deCONZ and UniFi to use config entry subclass (home-assistant#26173)
  Upgrade sqlalchemy to 1.3.8 (home-assistant#26331)
  Change evohome to asyncio client (home-assistant#26042)
  Add support for Supla switches (home-assistant#26188)
  Add a keypress service for AlarmDecoder (home-assistant#26100)
  Fix google_maps scan interval (home-assistant#26328)
  Upgrade youtube_dl to 2019.09.01 (home-assistant#26330)
  Fix onvif camera setup error (home-assistant#24585)
  UniFi - use entity registry disabled_by to control available entities  (home-assistant#26141)
  Fetch Onkyo current radio preset (home-assistant#26211)
  Add precision argument to the Range Filter (home-assistant#25874)
  Fix alexa bad temp sensors (home-assistant#26307)
  deCONZ - Dont update entry if data is equal
  Add Withings support (home-assistant#25154)
  Add support for Homekit accessory battery sensors (home-assistant#26210)
  ...
@lock lock Bot locked and limited conversation to collaborators Sep 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changes to evohome take minutes to appear in the UI

3 participants