Add device to mqtt camera#26238
Merged
emontnemery merged 4 commits intoSep 4, 2019
Merged
Conversation
probot-home-assistant
Bot
added
core
integration: mqtt
small-pr
MartinHjelmare
approved these changes
Aug 31, 2019
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Looks good!
@emontnemery can you confirm?
Contributor
|
Yes, this looks good, but a couple of things should be improved: We need to handle the case when updated device information is received, see #20442. Tests are also needed, with
|
Contributor
Author
|
@emontnemery Updated code and added tests, as you wrote. |
pgilad
added a commit
to pgilad/home-assistant
that referenced
this pull request
Sep 4, 2019
* dev: (87 commits) Add atome sensor platform (home-assistant#26197) Replaces IOError by OSError (home-assistant#26428) Entity registry doesn't overwrite with None (home-assistant#24275) Add device to mqtt camera (home-assistant#26238) Updated frontend to 20190904.0 (home-assistant#26421) Add prettier to vscode (home-assistant#26417) NSW Rural Fire Service icon for geolocation entities (home-assistant#26416) Update azure-pipelines-translation.yml for Azure Pipelines [ci skip] Translation update Update azure-pipelines-translation.yml for Azure Pipelines Update azure-pipelines-translation.yml for Azure Pipelines Update azure-pipelines-translation.yml for Azure Pipelines Update azure-pipelines-translation.yml for Azure Pipelines Bumped version to 0.98.3 Bump ISY994's PyISY dependency to 1.1.2 (home-assistant#26413) Fix state report (home-assistant#26406) Update to 0.1.13 (home-assistant#26402) Met, check for existing location (home-assistant#26400) Allow core config updated (home-assistant#26398) Fix race during initial Sonos group construction (home-assistant#26371) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Mqtt camera docs states there is device possible ( https://www.home-assistant.io/components/camera.mqtt/#device ) but from the code it doesn't seem to be supported. Added device support, copying solution from mqtt sensor.
Related issue (if applicable): fixes EliasKotlyar/Xiaomi-Dafang-Hacks#952
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass