Skip to content

Bump ISY994's PyISY dependency to 1.1.2#26413

Merged
balloob merged 1 commit into
home-assistant:devfrom
OverloadUT:fix-isy994-delays
Sep 4, 2019
Merged

Bump ISY994's PyISY dependency to 1.1.2#26413
balloob merged 1 commit into
home-assistant:devfrom
OverloadUT:fix-isy994-delays

Conversation

@OverloadUT
Copy link
Copy Markdown
Contributor

Description:

Fixed a major bug that was responsible for ISY events getting seemingly random delays up to 24 seconds. This is a really gigantic years-standing bug fix for all ISY users!

Extra special thanks to @altersis for discovering the root cause of this issue. It was indeed quite a tricky bug to locate.

Related issue (if applicable): n/a

Pull request with documentation 0for home-assistant.io (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

Fixed a major bug that was responsible for ISY events getting seemingly random delays up to 24 seconds
@balloob balloob added this to the 0.98.3 milestone Sep 4, 2019
@balloob balloob merged commit 22d3cf4 into home-assistant:dev Sep 4, 2019
@balloob
Copy link
Copy Markdown
Member

balloob commented Sep 4, 2019

Will get it released right away 👍

balloob pushed a commit that referenced this pull request Sep 4, 2019
Fixed a major bug that was responsible for ISY events getting seemingly random delays up to 24 seconds
@balloob balloob mentioned this pull request Sep 4, 2019
@MaikaiLife
Copy link
Copy Markdown

I hope it works, I've been having random delays with my ISY for over a year, and I've talked about it multiple times in the forums. This fix sounds exactly like the type of behavior I've been experiencing, congratulations on flushing this ou!

pgilad added a commit to pgilad/home-assistant that referenced this pull request Sep 4, 2019
* dev: (87 commits)
  Add atome sensor platform (home-assistant#26197)
  Replaces IOError by OSError (home-assistant#26428)
  Entity registry doesn't overwrite with None (home-assistant#24275)
  Add device to mqtt camera (home-assistant#26238)
  Updated frontend to 20190904.0 (home-assistant#26421)
  Add prettier to vscode (home-assistant#26417)
  NSW Rural Fire Service icon for geolocation entities (home-assistant#26416)
  Update azure-pipelines-translation.yml for Azure Pipelines
  [ci skip] Translation update
  Update azure-pipelines-translation.yml for Azure Pipelines
  Update azure-pipelines-translation.yml for Azure Pipelines
  Update azure-pipelines-translation.yml for Azure Pipelines
  Update azure-pipelines-translation.yml for Azure Pipelines
  Bumped version to 0.98.3
  Bump ISY994's PyISY dependency to 1.1.2 (home-assistant#26413)
  Fix state report (home-assistant#26406)
  Update to 0.1.13 (home-assistant#26402)
  Met, check for existing location (home-assistant#26400)
  Allow core config updated (home-assistant#26398)
  Fix race during initial Sonos group construction (home-assistant#26371)
  ...
@OverloadUT OverloadUT deleted the fix-isy994-delays branch September 4, 2019 21:52
@lock lock Bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants