Conversation
Allows values in a given range
When light.turn_off is invoked with a transition, the following payload was
sent to deCONZ via PUT to /light/N/state:
{ "bri": 0, "transitiontime": transition }
However, on recent versions of deCONZ (latest is 2.05.31 at the time of
writing) this does not turn off the light, just sets it to minimum brightness
level (brightness is clamped to minimum level the light supports without
turning it off).
This commit makes the code send this payload instead:
{ "on": false, "transitiontime": transition }
This works as intended and the light does transition to the 'off' state.
This change was tested with Philips Hue colored lights, IKEA colored lights
and IKEA white spectrum lights: they were all able to be turned off
successfully with the new payload, and none of them could be turned off with
the old payload.
* Add new RTS device Add new RTS Somfy device as cover-ExteriorVenetianBlindRTSComponent * add next device add next device
* Update nut.py Added input.frequency and a number of output parameters. * Update nut.py Fixed formatting issues Added "devices" fields * Separated "device.description" line to two lines. * Update nut.py Removed device.* sensors
* Force to use access_token if hass.auth.active * Not allow Basic auth with api_password if hass.auth.active * Block websocket api_password auth when hass.auth.active * Add legacy_api_password auth provider * lint * lint
* Add precipitations to daily forecast mode * Remove line breaks
Previous commit d4f7dfa successfully fixed the bug in which lights
would not turn off if a transition was specified, however if 'bri' is not
present in the payload of the PUT request set to deCONZ, then any
'transitiontime' ends up being ignored. This commit addresses the
unintended side effect by reintroducing 'bri', resulting in the following
payload:
{ "on": false, "bri": 0, "transitiontime": ... }
* Make fewer requests to the Rachio API * BREAKING: Rewrite Rachio component
* Remove some unused imports * Fix a flake8 E271
* Added WS endpoint for changing homeassistant password. * Remove change password helper. Don't require current password. * Restore current password verification. * Added tests. * Use correct send method
* Allow CORS requests to token endpoint * Tests * Fuck emulated hue * Clean up * Only cors existing methods
* Allow auth providers to influence is_active * Fix auth script test
balloob
requested review from
a team,
Danielhiversen,
Kane610,
bachya,
cdce8p,
dgomes,
rytilahti and
syssi
as code owners
ghost
assigned
Member
|
Can we include #15571 after someone has tested it out? |
…e update (#15571) * light.tplink: initialize min & max mireds only once, avoid i/o outside update * revert the index change * fix indent, sorry for overwriting your fix, balloob
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Platforms
Breaking Changes
Beta Fixes
All changes