deconz: fix light.turn_off with transition (2)

[lbschenkel]

Description:

Previous commit d4f7dfa successfully fixed the bug in which lights
would not turn off if a transition was specified, however if bri is not
present in the payload of the PUT request set to deCONZ, then any
transitiontime ends up being ignored. This commit addresses the
unintended side effect by reintroducing bri, resulting in the following
payload:

{ "on": false, "bri": 0, "transitiontime": ... }

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[Kane610]

Have you done some extra verification that this actually gets the wanted behavior? ;)

[lbschenkel]

Yes. This is the exact version confirmed to be working with for both the "off" state and also for transitions being honoured. But I would welcome if @vandalon could do the same modification in his system and confirm that it also works for him, before this gets merged.

[Kane610]

@lbschenkel yes that would be good!

[vandalon]

Will do in an hour. At swimming lessons with the kids now :)

[Kane610]

No hurry, we got two weeks to get this merged :)

[vandalon]

To bad i can not remotely see how the bulb reacts :) I've got everything in place just need to see the blub :)

[vandalon]

Ok, girlfriend confirmed slowly going off :) so it works

[Kane610]

Tell me when you're satisfied with the testing

[vandalon]

Well there is still something weird. Running the command from HA works, running it via Node Red it still turns off the lights instantly. where node red sends the exact same command to HA.

[lbschenkel]

Please enable pydeconz debug logging and post the payloads here from both scenarios, let's see if there's any difference.

[vandalon]

My bad! I made a config error within Node Red. All works perfectly!

[lbschenkel]

I am having a serious trouble typing transitiontime correctly in commit messages. I have taken the opportunity to amend it before merging. No code changes.

[Kane610]

Good to go then?

[lbschenkel]

Yes from me. @vandalon?

[vandalon]

Yes, absolutely

[lbschenkel]

Thanks @Kane610. I'm not so familiar with the release process, how much time can we typically expect for code landing in dev to appear on a release?

[Kane610]

If you're running on stable release you can expect this to be available in 0.74, in ~3 weeks

[vandalon]

In the meanwhile you can place the adjusted deconz.py in custom_components/light/