Add additional parameters to NUT UPS sensor#15066
Merged
fabaff merged 4 commits intohome-assistant:devfrom Jun 30, 2018
Merged
Conversation
Added input.frequency and a number of output parameters.
Contributor
homeassistant
added
cla-needed
platform: sensor.nut
small-pr
ghost
added
the
houndci-bot
reviewed
Jun 20, 2018
| 'output.voltage': ['Output Voltage', 'V', 'mdi:flash'], | ||
| 'output.voltage.nominal': ['Nominal Output Voltage', 'V', 'mdi:flash'], | ||
| 'output.frequency': ['Output Frequency', 'hz', 'mdi:flash'], | ||
| 'output.frequency.nominal': ['Nominal Output Frequency', 'hz', 'mdi:flash'], |
There was a problem hiding this comment.
line too long (80 > 79 characters)
| 'input.voltage.nominal': ['Nominal Input Voltage', 'V', 'mdi:flash'], | ||
| 'input.frequency': ['Input Line Frequency','hz','mdi:flash'], | ||
| 'input.frequency.nominal': ['Nominal Input Line Frequency','hz','mdi:flash'], | ||
| 'input.frequency.status': ['Input Frequency Status','','mdi:information-outline'], |
There was a problem hiding this comment.
missing whitespace after ','
line too long (86 > 79 characters)
| 'input.voltage': ['Input Voltage', 'V', 'mdi:flash'], | ||
| 'input.voltage.nominal': ['Nominal Input Voltage', 'V', 'mdi:flash'], | ||
| 'input.frequency': ['Input Line Frequency','hz','mdi:flash'], | ||
| 'input.frequency.nominal': ['Nominal Input Line Frequency','hz','mdi:flash'], |
There was a problem hiding this comment.
missing whitespace after ','
line too long (81 > 79 characters)
| ['Voltage Transfer Reason', '', 'mdi:information-outline'], | ||
| 'input.voltage': ['Input Voltage', 'V', 'mdi:flash'], | ||
| 'input.voltage.nominal': ['Nominal Input Voltage', 'V', 'mdi:flash'], | ||
| 'input.frequency': ['Input Line Frequency','hz','mdi:flash'], |
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Fix the hound and lint issues and we can merge this.
Fixed formatting issues Added "devices" fields
| 'device.mfr': ['Device manufacturer', '', 'mdi:information-outline'], | ||
| 'device.serial': ['Device serial', '', 'mdi:information-outline'], | ||
| 'device.type': ['Device type', '', 'mdi:information-outline'], | ||
| 'device.description': ['Device description', '', 'mdi:information-outline'], |
Member
There was a problem hiding this comment.
This line is too long. Do a line break.
MartinHjelmare
requested changes
Jun 25, 2018
| ['Device physical location', '', 'mdi:information-outline'], | ||
| 'device.part': ['Device part number', '', 'mdi:information-outline'], | ||
| 'device.macaddr': | ||
| ['Device network address', '', 'mdi:information-outline'], |
Member
There was a problem hiding this comment.
All of these above are static information about the device and should not be added as sensors. We will probably soon implement a "device" concept related to each entity where this type of information can be stored. But we shouldn't add it to the state machine as entity states at this point.
Contributor
Author
There was a problem hiding this comment.
Makes sense. Will remove.
Removed device.* sensors
MartinHjelmare
changed the title
Member
|
Would be good to also list the new options in the documentation. |
2 tasks
fabaff
approved these changes
Jun 30, 2018
awarecan
pushed a commit
to awarecan/home-assistant
that referenced
this pull request
Jul 16, 2018
* Update nut.py Added input.frequency and a number of output parameters. * Update nut.py Fixed formatting issues Added "devices" fields * Separated "device.description" line to two lines. * Update nut.py Removed device.* sensors
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Added additional parameters to NUT UPS sensor
input.frequency
output.current
output.voltage
output.frequency
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5623
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: