Skip to content

Add precipitations to Openweathermap daily forecast mode#15240

Merged
fabaff merged 2 commits intohome-assistant:devfrom
Yevgenium:patch-1
Jul 1, 2018
Merged

Add precipitations to Openweathermap daily forecast mode#15240
fabaff merged 2 commits intohome-assistant:devfrom
Yevgenium:patch-1

Conversation

@Yevgenium
Copy link
Copy Markdown
Contributor

@Yevgenium Yevgenium commented Jul 1, 2018 •
edited
Loading

Description:

Add precipitations to Openweathermap daily forecast mode

Example entry for configuration.yaml (if applicable):

weather:
  - platform: openweathermap
    api_key: YOUR_API_KEY
    mode: daily

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Jul 1, 2018
@ghost ghost assigned fabaff Jul 1, 2018
fabaff
fabaff approved these changes Jul 1, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@Yevgenium
Copy link
Copy Markdown
Contributor Author

Yevgenium commented Jul 1, 2018

Thank you

@fabaff fabaff merged commit c0229eb into home-assistant:dev Jul 1, 2018
@ghost ghost removed the in progress label Jul 1, 2018
@Yevgenium Yevgenium deleted the patch-1 branch July 1, 2018 14:46
awarecan pushed a commit to awarecan/home-assistant that referenced this pull request Jul 16, 2018
@Yevgenium @awarecan
Add precipitations to Openweathermap daily forecast mode (home-assist…
d70acb0 
…ant#15240)

* Add precipitations to daily forecast mode

* Remove line breaks
@balloob balloob mentioned this pull request Jul 20, 2018
Merged
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@Yevgenium
Add precipitations to Openweathermap daily forecast mode (home-assist…
2942726 
…ant#15240)

* Add precipitations to daily forecast mode

* Remove line breaks
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fabaff fabaff fabaff approved these changes

Assignees

@fabaff fabaff

Labels

cla-signed integration: openweathermap small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Yevgenium @fabaff @homeassistant