Allow less modern ciphers for outgoing connections#15546
Merged
Conversation
ghost
assigned
Contributor
|
LGTM |
balloob
added a commit
that referenced
this pull request
Jul 19, 2018
Merged
Closed
michaeldavie
pushed a commit
to michaeldavie/home-assistant
that referenced
this pull request
Jul 31, 2018
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
After the SSLContext incident (Fixed in #15483) I went too strict, enforcing only modern ciphers to be used when making connections to servers. This resulted in a couple of integrations breaking because the servers were using older ciphers.
After some debate, we've decided that server SSL is our issue and we will enforce Mozilla modern cipher config recommendation.
For the client, we will use the Mozilla CA bundle and use the default context provided by the current Python version.
Related issue (if applicable):
Checklist:
tox. Your PR cannot be merged unless tests pass