Skip to content

Fix flux_led turning on with color or effect#15472

Merged
balloob merged 1 commit intohome-assistant:devfrom
amelchio:flux_led-turnOn
Jul 15, 2018
Merged

Fix flux_led turning on with color or effect#15472
balloob merged 1 commit intohome-assistant:devfrom
amelchio:flux_led-turnOn

Conversation

@amelchio
Copy link
Copy Markdown
Contributor

Description:

This reverts a small part of #14713 (0ca1c40) since it is apparently causing some issues.

I do not have the hardware to test this but I want to fix it since I approved the change. CC: @oblogic7

The revert means that #14713 (comment) is still not addressed.

Related issue (if applicable): fixes #15413, fixes #15448

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@ghost ghost assigned amelchio Jul 15, 2018
@ghost ghost added the in progress label Jul 15, 2018
@balloob balloob merged commit 7d0cc7e into home-assistant:dev Jul 15, 2018
@ghost ghost removed the in progress label Jul 15, 2018
@soberstadt
Copy link
Copy Markdown
Contributor

This fixed the problem to for me, thanks!

@oblogic7
Copy link
Copy Markdown
Contributor

Thanks for getting this @amelchio. I went to look at it and ran into issues with my dev environment.

@amelchio amelchio added this to the 0.74 milestone Jul 20, 2018
@amelchio
Copy link
Copy Markdown
Contributor Author

Since @soberstadt reports that this PR fixes the issue, I am adding it to the 0.74 milestone.

@balloob balloob removed this from the 0.74 milestone Jul 20, 2018
@balloob
Copy link
Copy Markdown
Member

balloob commented Jul 20, 2018

No need for the milestone, it was already part of 0.74 👍

@amelchio
Copy link
Copy Markdown
Contributor Author

Ah, great. Sorry for missing that.

@balloob balloob mentioned this pull request Jul 20, 2018
@kineticscreen
Copy link
Copy Markdown

Yep this fixes the issue with brightness / colour states being ignored when the lights are triggered from an off state, but as listed breaks the nice 'fade on' behaviour that the previous fix reinstated.

@amelchio
Copy link
Copy Markdown
Contributor Author

@kineticscreen Yeah, please report that in a separate issue and someone that has the flux_led hardware can hopefully make a change that does not break other features.

@kineticscreen
Copy link
Copy Markdown

I have literally no idea how to do that

michaeldavie pushed a commit to michaeldavie/home-assistant that referenced this pull request Jul 31, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flux_led light won't turn on directly to a new color Lights using flux_led component does not turn on with effects

6 participants