Fix flux_led turning on with color or effect#15472
Merged
balloob merged 1 commit intohome-assistant:devfrom Jul 15, 2018
Merged
Fix flux_led turning on with color or effect#15472balloob merged 1 commit intohome-assistant:devfrom
balloob merged 1 commit intohome-assistant:devfrom
Conversation
Contributor
|
This fixed the problem to for me, thanks! |
Contributor
|
Thanks for getting this @amelchio. I went to look at it and ran into issues with my dev environment. |
Contributor
Author
|
Since @soberstadt reports that this PR fixes the issue, I am adding it to the 0.74 milestone. |
Member
|
No need for the milestone, it was already part of 0.74 👍 |
Contributor
Author
|
Ah, great. Sorry for missing that. |
Merged
|
Yep this fixes the issue with brightness / colour states being ignored when the lights are triggered from an off state, but as listed breaks the nice 'fade on' behaviour that the previous fix reinstated. |
Contributor
Author
|
@kineticscreen Yeah, please report that in a separate issue and someone that has the flux_led hardware can hopefully make a change that does not break other features. |
|
I have literally no idea how to do that |
michaeldavie
pushed a commit
to michaeldavie/home-assistant
that referenced
this pull request
Jul 31, 2018
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This reverts a small part of #14713 (0ca1c40) since it is apparently causing some issues.
I do not have the hardware to test this but I want to fix it since I approved the change. CC: @oblogic7
The revert means that #14713 (comment) is still not addressed.
Related issue (if applicable): fixes #15413, fixes #15448
Checklist:
tox.If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.