Disallow use insecure_example auth provider in configuration.yml#15504
Merged
balloob merged 2 commits intohome-assistant:devfrom Jul 17, 2018
Merged
Disallow use insecure_example auth provider in configuration.yml#15504balloob merged 2 commits intohome-assistant:devfrom
balloob merged 2 commits intohome-assistant:devfrom
Conversation
ghost
added
the
houndci-bot
reviewed
Jul 17, 2018
tests/test_config.py
Outdated
| assert len(hass.auth.auth_providers) == 2 | ||
|
|
||
|
|
||
| async def test_auth_provider_config(hass): |
There was a problem hiding this comment.
redefinition of unused 'test_auth_provider_config' from line 796
tests/test_config.py
Outdated
| } | ||
| await config_util.async_process_ha_core_config(hass, core_config) | ||
|
|
||
| assert hass.auth.active == True |
There was a problem hiding this comment.
comparison to True should be 'if cond is True:' or 'if cond:'
awarecan
force-pushed
the
disabllow-insecure-auth-prov
branch
from
6aea384 to
a431dcb
Compare
awarecan
force-pushed
the
disabllow-insecure-auth-prov
branch
from
a431dcb to
7fe708c
Compare
balloob
approved these changes
Jul 17, 2018
Member
|
Great! I think at a later point we can move the insecure example to the test dir and just patch it in place with a fixture when we want to do testing. |
Contributor
Author
|
I think it is okay keep insecure_example in place, so that other developer can have an example to follow. No one will look at tests folder I believe. |
Merged
michaeldavie
pushed a commit
to michaeldavie/home-assistant
that referenced
this pull request
Jul 31, 2018
…e-assistant#15504) * Disallow use insecure_example auth provider in configuration.yml * Add unit test for auth provider config validate
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
…e-assistant#15504) * Disallow use insecure_example auth provider in configuration.yml * Add unit test for auth provider config validate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Disallow use insecure_example auth provider in configuration.yml
The insecure_example auth provider is for testing only.
Related issue (if applicable): fixes #15199
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: