WIP Adds facebox_face_detect#14279
Closed
robmarkcole wants to merge 85 commits intohome-assistant:devfrom
robmarkcole:facebox-detect
Closed
WIP Adds facebox_face_detect#14279robmarkcole wants to merge 85 commits intohome-assistant:devfrom robmarkcole:facebox-detect
robmarkcole wants to merge 85 commits intohome-assistant:devfrom
robmarkcole:facebox-detect
Conversation
* Fixed bug - unable to set base readaonly property * PR fixes * Added line
* Fix race condition for component loaded before listening * async/await syntax
* Broadlink switch, fixes issue #13799 * slugify
* Bumped pypollencom to 1.1.2 * Updated requirements_all.txt
This reverts commit 6fa60c4.
* Order the output of the automation editor * Lint
* Catch exception for KeyError * Use get and added test
* Handle HomeKit configuration failure more cleanly Add support for handling cases where HomeKit configuration fails, and give the user more information about what to do. * Don't consume the exception for a homekit.UnknownError If we get an UnknownError then we should alert the user but also still generate the backtrace so there's actually something for them to file in a bug report.
* Setup all-linking service * Remove extra line * Remove linefeed and tab escape chars * Add services delete_all_link, load_all_link_database and print_all_link_database * Check if reload is set * Confirm entity is InsteonPLMEntity before attempting to load or print ALDB * Debug load and print ALDB * Debug print aldb * Debug print_aldb * Get entity via platform * Track Insteon entities in component * Store entity list in hass.data * Add entity to hass.data * Add ref to hass in InsteonPLMEntity * Pass hass correctly to InsteonPLMBinarySensor * Fix reference to ALDBStatus.PARTIAL * Print ALDB record as string * Get ALDB record from memory address * Reformat ALDB log output * Add print_im_aldb service * Remove reference to self in print_aldb_to_log * Remove reference to self in print_aldb_to_log * Fix spelling issue with load_all_link_database service * Bump insteonplm to 0.9.1 * Changes from code review * Code review changes * Fix syntax error * Correct reference to cv.boolean and update requirements * Update requirements * Fix flake8 errors * Reload as boolean test * Remove hass from entity init
# Conflicts: # homeassistant/components/image_processing/facebox_face_detect.py
Contributor
Author
|
I've followed the dev instructions (to the best of my understanding)but I still repeatedly run into this issue of conflict and hundreds of other files being modified. Is there a bullet proof approach to avoid this? |
Member
|
I often use the |
Contributor
Author
|
Thanks for the advice @MartinHjelmare |
Member
|
Make sure you backup your changed code somehow first. Then you can try this: Disclaimer: I haven't tried it myself. |
Contributor
Author
|
This branch is a mess so I'm going to create a fresh one & PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #14248
Description:
Adds component for face detection (number of faces) using facebox. Run facebox with:
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<5300>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: