Fix Gogogate2 'available' attribute#13728
Merged
MartinHjelmare merged 16 commits intohome-assistant:devfrom Apr 7, 2018
Merged
Fix Gogogate2 'available' attribute#13728MartinHjelmare merged 16 commits intohome-assistant:devfrom
MartinHjelmare merged 16 commits intohome-assistant:devfrom
Conversation
Member
|
Please rebase your branch so that there's only the new commits from this PR. |
Contributor
Author
|
@MartinHjelmare I'm having some issues rebasing this PR - whoever merges this PR - can they just use the Rebase and merge option in Github please? https://stackoverflow.com/a/39707453/5760250 |
Member
|
I'll squash and merge. But next time please remember to start your branch from a freshly synced dev branch. |
MartinHjelmare
changed the title
Member
|
Thanks. Was really a good idea to make those changes in the GitHub editor. |
balloob
pushed a commit
that referenced
this pull request
Apr 18, 2018
* Fixed bug - unable to set base readaonly property * PR fixes * Added line
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested some of the recent changes in #13467 by @fabaff and fixed an issue with setting the available property