Skip to content

WIP: Adds facebox_face_detect#14248

Closed
robmarkcole wants to merge 57 commits intohome-assistant:devfrom
robmarkcole:facebox
Closed

WIP: Adds facebox_face_detect#14248
robmarkcole wants to merge 57 commits intohome-assistant:devfrom
robmarkcole:facebox

Conversation

@robmarkcole
Copy link
Copy Markdown
Contributor

@robmarkcole robmarkcole commented May 2, 2018 •
edited
Loading

Description:

Adds component for face detection (number of faces) using facebox. Run facebox with:

MB_KEY="INSERT-YOUR-KEY-HERE"

docker run -p 8080:8080 -e "MB_KEY=$MB_KEY" -e "MB_FACEBOX_DISABLE_RECOGNITION=true" machinebox/facebox

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<5300>

Example entry for configuration.yaml (if applicable):

image_processing:
  - platform: facebox_face_detect
    ip_address: 192.168.0.1
    port: 8080
    source:
      - entity_id: camera.local_file

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@robmarkcole
Adds Facebox
cfd69c6
@robmarkcole
Update to ImageProcessingFaceEntity
fe17997 
Use ImageProcessingFaceEntity
@robmarkcole
Remove confidence
ed4d850 
Confidence overcomplicates the component and is meaningless
@robmarkcole
Adds facebox
1937b16
@robmarkcole
Copy link
Copy Markdown
Contributor Author

robmarkcole commented May 2, 2018

Test giving error:

Error on receive image from entity: Can't connect to http://127.0.0.1:8123/api/camera_proxy/camera.demo_camera?token=612eded1d17a290f08ddcf78ec5980ee4b9ea101ef65685020e9862f85702ffd

@balloob advises that in the latest dev, calling the camera scan service does not cause the camera to request a frame so I'm not sure what is wrong here

@balloob
Copy link
Copy Markdown
Member

balloob commented May 2, 2018

My bad, I implemented that in #14231 which has not been merged yet.

mjg59 and others added 21 commits May 3, 2018 06:57
@mjg59 @robmarkcole
Fix Python 3.6 compatibility for HomeKit controller (#14160)
b2ad686 
Python 3.6's http client passes an additional argument to _send_output,
so add that to the function definition.
@Kane610 @robmarkcole
deCONZ allow unloading of config entry (#14115)
dd18b4c 
* Working but incomplete

* Remove events on unload

* Add unload test

* Fix failing sensor test

* Improve unload test

* Move DeconzEvent to init

* Fix visual under-indentation
@fabaff @robmarkcole
Upgrade netdisco to 1.4.0 (#14152)
fadc845
@escoand @robmarkcole
Add precipitation to OpenWeatherMap forecast (#13971)
04a3322 
* add initial precipitation support

* move attr to component

* remove blank line

* add forecast attributes to platform and update demo

* add tests

* break long lines

* calc lower temp correctly

* move all new attributes to component

* convert temp low only when existing
@Hate-Usernames @robmarkcole
Allow transitioning to colour temp for tradfri (#14157)
5d37c32
@balloob @robmarkcole
Add mitemp_bt to coverage
4d48c99
@balloob @robmarkcole
Another coverage fix
bb2a4db
@dingusdk @robmarkcole
Added update_interval to maxcube (#14143)
93d9d7b
@amelchio @robmarkcole
Revert Hue color state to be xy-based (#14154)
713fce6
@rcloran @robmarkcole
zha: Support remotes/buttons (#12528)
f2e8954
@fabaff @robmarkcole
Upgrade numpy to 1.14.3 (#14187)
5b36d29
@OttoWinter @robmarkcole
Improve chromecast disconnection logic (#14190)
d323257 
* Attempt Cast Fix

* Cleanup
@cdce8p @robmarkcole
Added CONF_IP_ADDRESS to HomeKit (#14163)
bf8d205
@balloob @robmarkcole
Do not sync entities with an empty name (#14181)
37e8b7d
@balloob @robmarkcole
Fix poorly formatted automations (#14196)
f26ff86
@msubra @robmarkcole
Updating darksky default update interval to 5 mins (#14195)
a42269d 
With Darksky allowing only 1000 API requests per day, 2 minutes retry seems to be bit closer to running over the limit and actually it did for 5 days in my account. Hence proposing a change to 5 minutes to keep the API happy and also it doesn't hurt to check the weather for every 5 mins than 2 mins someone lives in Jupiter :-P
@mvn23 @robmarkcole
Fix TypeError on round(self.humidity) (fixes #13116) (#14174)
43058e5 
* Fix TypeError on round(self.humidity)

Some weather platforms postpone the first data fetch for a while on init. As a result round(self.humidity is called before it is assigned a value, producing an error. This is a fix for that.

* Rewrite to avoid false negative evaluation

As per the suggestion from @OttoWinter, rewrite to avoid matching e.g. 0.0 as false.
@balloob @robmarkcole
Add room hint support to Google Assistant cloud (#14180)
c04a087
@pschmitt @robmarkcole
Update CODEOWNERS (#14214)
ae5b9be
@dgomes @robmarkcole
Fixes #14169 (Upgrade pyupnp-async to 0.1.0.2) (#14210)
e035ffa 
* Fixes #14169 (upstream version bump)

* bump pyupnp-async version
@rcloran @robmarkcole
zha: Clean up binary_sensor listener registration/state updates (#14197)
3ba805a 
- Instead of registering listeners in the entity __init__, do it in
   async_added_to_hass to avoid errors updating an entity which isn't fully
   set up yet
 - Change from schedule_update_ha_state to async_schedule_update_ha_state
iMicknl and others added 7 commits May 3, 2018 06:57
@iMicknl @robmarkcole
Add PostNL sensor (Dutch Postal Services) (#12366)
3ae85c6 
* Add basic PostNL sensor (WIP)

* Update PostNL sensor

* Bump version

* Small updates to PostNL package based on feedback

* Remove unused import

* Pass api to sensor

* Refactor based on feedback

* Update based on feedback

* Fix feedback

* Clean up

* Bugfiix

* Bugfix

* SCAN_INTERVAL fix

* Remove unused import

* Refactor for new wrapper implementation

* Update postnl package requirement

* Change throttle logic

* Update package version

* Add new line

* Minor changes

* Change refresh time to 30 minutes

* Update requirements_all.txt
@perosb @robmarkcole
python_openzwave update config service (#12060)
dd1548a 
* update python-openzwave to 4.1.0

* add service which updates the configuration files from github

* 0.4.3
@andrey-git @robmarkcole
Add unique_id to zwave node entity (#14201)
aa6dba3 
* Add unique_id to zwave node entity

* Wait 30s before adding zwave node if its unique_id is not ready

* Use only node_id in unique_id. Update name, manufacturer, and product attributes on node update.
@marthoc @robmarkcole
Add prereqs for HomeKit Controller (#14172)
9adbf71
@dgomes @robmarkcole
Restores switch state, case the switch is optimistic (#14151)
c33511c 
* Add restore_state to optimistic switch

* no need to schedule update

* test added

* lint

* new async syntax

* lint
@giangvo @robmarkcole
Issue/add template fans (#12027)
4927309 
* add template fan

* add-template: address PR comments

* add-template: remove unused import

* add-template: revert async_track_state_change change

* add-template: use yield from

* Revert "add-template: use yield from"

This reverts commit 1e05371.

* add-template: use yield

* add-template: remove unused import

* add-template: remove async_add_job usages

* use components

* add-template: use async/await

* add-template: fix style

* add-template: remove str()

* address pr comments

* fix style
@robmarkcole
Make facebox_face_detect
3fec8d5 
Clarify that this component is for face detection by renaming component
and class
@robmarkcole robmarkcole requested review from a team, Kane610, cdce8p, dgomes and kellerza as code owners May 3, 2018 05:57
@robmarkcole robmarkcole requested a review from a team May 3, 2018 05:57
@robmarkcole robmarkcole requested a review from a team as a code owner May 3, 2018 05:57
@robmarkcole robmarkcole changed the title WIP: Adds image_processing component Facebox WIP: Adds image_processing component facebox_face_detect May 3, 2018
@robmarkcole robmarkcole changed the title WIP: Adds image_processing component facebox_face_detect WIP: Adds facebox_face_detect May 3, 2018
@robmarkcole
Put name in correct place
a69a4c5 
Fix position of name
@robmarkcole robmarkcole mentioned this pull request May 3, 2018
Closed
2 tasks
@cdce8p cdce8p removed their request for review May 3, 2018 06:58
@robmarkcole
Copy link
Copy Markdown
Contributor Author

robmarkcole commented May 4, 2018 •
edited
Loading

OK I'm in a world of pain trying to resolve all these conflicts. I'm afraid I am going to have to resort to my old trick of deleting my fork and creating a fresh one

@robmarkcole robmarkcole closed this May 4, 2018
@robmarkcole robmarkcole mentioned this pull request May 4, 2018
Closed
8 tasks
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dgomes dgomes Awaiting requested review from dgomes

@Kane610 Kane610 Awaiting requested review from Kane610

@kellerza kellerza Awaiting requested review from kellerza

Assignees

No one assigned

Labels

cla-signed integration: facebox new-platform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.