Order the output of the automation editor#14019
Merged
Conversation
houndci-bot
reviewed
Apr 20, 2018
| if key in new_value: | ||
| updated_value[key] = new_value[key] | ||
|
|
||
| # We cover all fields above, but just in case we start supporting more fields |
There was a problem hiding this comment.
line too long (85 > 79 characters)
| 'action': [], | ||
| } | ||
| assert written[0] == orig_data | ||
|
|
| """Test Automation config panel.""" | ||
| import asyncio | ||
| import json | ||
| from unittest.mock import patch, MagicMock |
There was a problem hiding this comment.
'unittest.mock.MagicMock' imported but unused
| @@ -0,0 +1,85 @@ | |||
| """Test Automation config panel.""" | |||
| import asyncio | |||
balloob
added a commit
that referenced
this pull request
Apr 25, 2018
* Order the output of the automation editor * Lint
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The automation editor lost the ordering of the keys, making it crazy confusing for people trying to edit the YAML by hand.
Example entry for
automation.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: