HomeKit: Add more device classes for contact sensor#14051
Merged
cdce8p merged 1 commit intohome-assistant:devfrom Apr 23, 2018
marthoc:homekit_door_classes
Merged
HomeKit: Add more device classes for contact sensor#14051cdce8p merged 1 commit intohome-assistant:devfrom marthoc:homekit_door_classes
cdce8p merged 1 commit intohome-assistant:devfrom
marthoc:homekit_door_classes
Conversation
homeassistant
added
cla-signed
integration: homekit
small-pr
cdce8p
approved these changes
Apr 23, 2018
Member
cdce8p
left a comment
cdce8p
left a comment
There was a problem hiding this comment.
Looks good! Thanks for adding these cases 🥇 Can you update the documentation for it?
Member
|
The doc PR against the |
Contributor
Author
|
@cdce8p I’ll take care of adding these to the docs in the next couple of days. Thanks! |
Member
|
@marthoc I've create the doc PR for this change already, since I also wanted to change the device classes to lower case in the doc. home-assistant/home-assistant.io#5254 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The current binary sensor implementation in HomeKit does not include the door, garage door, or window binary sensor device classes present in Home Assistant, leading to binary sensor entities with those classes being created in HomeKit as occupancy sensors. This PR fixes this minor annoyance by ensuring that the door, garage door, and window binary sensor device classes are created as contact sensors in HomeKit.
Further tests may be required (or an expansion of the current tests); please advise if so and I’ll write them.
Related issue (if applicable): N/A
Pull request in home-assistant.github.io with documentation (if applicable): N/A
Example entry for
configuration.yaml(if applicable):N/A
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: