Fix call to parent broadlink switch#13906
Merged
MartinHjelmare merged 2 commits intodevfrom Apr 17, 2018
Merged
Conversation
homeassistant
added
cla-signed
platform: switch.broadlink
small-pr
MartinHjelmare
changed the title
MartinHjelmare
approved these changes
Apr 15, 2018
MartinHjelmare
requested changes
Apr 15, 2018
| def __init__(self, friendly_name, device): | ||
| """Initialize the switch.""" | ||
| super().__init__(friendly_name, device, None, None) | ||
| super().__init__(friendly_name, friendly_name, device, None, None) |
Member
There was a problem hiding this comment.
As mentioned in the related issue, this should be slugified before used for the entity_id. Probably do that in the parent.
balloob
pushed a commit
that referenced
this pull request
Apr 18, 2018
* Broadlink switch, fixes issue #13799 * slugify
Merged
Merged
ghost
added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Broadlink switch, fixes #13799