Skip to content

Onkyo: SUPPORT_VOLUME_STEP#14299

Merged
syssi merged 1 commit intohome-assistant:devfrom
rsmeral:onkyo-volume-steps
May 5, 2018
Merged

Onkyo: SUPPORT_VOLUME_STEP#14299
syssi merged 1 commit intohome-assistant:devfrom
rsmeral:onkyo-volume-steps

Conversation

@rsmeral
Copy link
Copy Markdown
Contributor

@rsmeral rsmeral commented May 5, 2018

Description:

This is broken off of #14053, where it was mixed with another issue.

  • Added support for volume steps
    • the underlying library directly supports it and translates to a receiver-native single unit of volume
    • without this fix, volume up/down is subject to the default media_player behaviour of stepping by 10% which seems too coarse for most receivers

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@syssi syssi merged commit 2e8eaf4 into home-assistant:dev May 5, 2018
@balloob balloob mentioned this pull request May 11, 2018
Merged
@rsmeral rsmeral mentioned this pull request May 12, 2018
Closed
2 tasks
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@syssi syssi syssi approved these changes

Assignees

No one assigned

Labels

cla-signed integration: onkyo small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rsmeral @syssi @homeassistant