This repository was archived by the owner on Feb 8, 2024. It is now read-only.
SharedDirectoryMoveRequest#1045
Merged
ibeckermayer merged 59 commits intomasterfrom Jul 28, 2022
Merged
Conversation
added 30 commits
July 6, 2022 15:53
… previously janky validity checks
… previously janky validity checks
…-file-system-access
added 9 commits
July 19, 2022 17:56
…wever for big directories (like node_modules) this takes forever. Going to try a non-Promise.all version
… and ensures all throws are handled
ibeckermayer
requested review from
JanKaczmarkiewicz,
hatched,
kimlisa,
ravicious,
rudream and
zmb3
kimlisa
approved these changes
Jul 28, 2022
Contributor
kimlisa
left a comment
kimlisa
left a comment
There was a problem hiding this comment.
hm, i don't see what you see on console, but this is work in progress so I didn't worry too much about it.
i tried moving a file into another folder inside the shared directory but it just pauses on this (i double checked i was on the right branch this time)
| decodeSharedDirectoryMoveRequest( | ||
| buffer: ArrayBuffer | ||
| ): SharedDirectoryMoveRequest { | ||
| let dv = new DataView(buffer); |
Contributor
There was a problem hiding this comment.
i think most of these should be const, same as above (or rather this whole file).
Author
@kimlisa I think you're just not viewing the debug logs in the console. You need to click on "Verbose" to see the
The on screen behavior is correct 👍 |
ibeckermayer
force-pushed
the
isaiah/sd-move-request
branch
from
ba2ee1b to
aa4f712
Compare
ibeckermayer
pushed a commit
that referenced
this pull request
Aug 23, 2022
ibeckermayer
pushed a commit
that referenced
this pull request
Aug 24, 2022
* `SharedDirectoryInfoResponse` (#996) * `SharedDirectoryListRequest` (#999) * `SharedDirectoryListResponse` (#1000) * `SharedDirectoryReadRequest` (#1003) * `SharedDirectoryReadResponse` (#1005) * `SharedDirectoryWriteRequest` (#1007) * `SharedDirectoryWriteResponse` (#1008) * Tidy up `sharedDirectoryManager` (#1010) * `SharedDirectoryMoveRequest` (#1045) * `SharedDirectoryMoveResponse` (#1074) * `SharedDirectoryCreateRequest` and `SharedDirectoryCreateResponse` (#1090) * SharedDirectoryDeleteRequest and SharedDirectoryDeleteResponse (#1096) * Add warning dialog for unsupported browsers for directory sharing (#1110) * updates yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires backport to v9/v10
How to test manually
webappstruewebapps/packages/teleport/src/config.ts
Line 32 in becfad3
yarn start-teleport --target=https://ec2-35-171-27-185.compute-1.amazonaws.com/What to expect
Go to the top right
...menu and clickShare Directory(X-out of the "uncaught exception" screen if you get it). The directory you select should show up in the File Explorer as a shared drive
The drive should be navigable as well should any folders within it
Try moving the file from one folder in the shared directory to another, and you should see something like
in the console