SharedDirectoryMoveRequest and SharedDirectoryMoveResponse#14959
Merged
ibeckermayer merged 62 commits intomasterfrom Aug 14, 2022
Merged
SharedDirectoryMoveRequest and SharedDirectoryMoveResponse#14959ibeckermayer merged 62 commits intomasterfrom
SharedDirectoryMoveRequest and SharedDirectoryMoveResponse#14959ibeckermayer merged 62 commits intomasterfrom
Conversation
jakule
reviewed
Jul 28, 2022
Contributor
jakule
left a comment
jakule
left a comment
There was a problem hiding this comment.
Can you add some tests? I don't see any in either Go or Rust code.
Contributor
Author
I'm of the opinion that its still more efficient to test this section manually (against a reference Microsoft RDP implementation) than to figure out the right way to do automated tests, so I'm continuing to go with that until we've implemented all the core functionality (create/read/write/move/delete) and then will go back and add automated tests. |
ibeckermayer
changed the title
SharedDirectoryMoveRequest and part of SharedDirectoryMoveResponseSharedDirectoryMoveRequest and SharedDirectoryMoveResponse
jakule
approved these changes
Aug 1, 2022
xacrimon
approved these changes
Aug 11, 2022
Contributor
|
@ibeckermayer See the table below for backport results.
|
ibeckermayer
pushed a commit
that referenced
this pull request
Aug 23, 2022
ibeckermayer
pushed a commit
that referenced
this pull request
Aug 23, 2022
ibeckermayer
pushed a commit
that referenced
this pull request
Sep 7, 2022
…ring) (#15770) * Windows Desktop Directory Sharing (#13630) * `IRP_MJ_CREATE` (#12665) * `IRP_MJ_QUERY_INFORMATION` (#12717) * `IRP_MJ_CLOSE` (#12729) * Refactor rdpdr client (#12750) * Adding logic for `FILE_SUPERSEDE` (#12829) * Improve `process_irp_create` (#12830) * adds return statements that got lost in a merge * `IRP_MJ_DIRECTORY_CONTROL` (#12870) * `FileFullDirectoryInformation` (#12908) * Improve `ClientDriveQueryDirectoryResponse.encode()` (#12912) * `IRP_MJ_QUERY_VOLUME_INFORMATION` (#13071) * Fix Shared Directory Request handling when feature is disabled (#13439) * IRP_MJ_READ, IRP_MJ_WRITE, and IRP_MJ_SET_INFORMATION (#13995) * Adds constants for sizing calculations (#14051) Co-authored-by: Łukasz Kozłowski <lukasz.kozlowski@goteleport.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com> * `UnixPath` and `WindowsPath` (#14267) * `SharedDirectoryMoveRequest` and `SharedDirectoryMoveResponse` (#14959) * `SharedDirectoryCreateResponse` update (#15289) * Fix `process_irp_set_information` (#15364) * Sanitize Rust Debug Logs (#15743) * updates rdp-rs ref to include licensing changes * Updates rdp-rs ref and fixes Cargo Co-authored-by: Łukasz Kozłowski <lukasz.kozlowski@goteleport.com> Co-authored-by: Zac Bergquist <zac.bergquist@goteleport.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Rust and Go piping and logic for
SharedDirectoryMoveRequestandSharedDirectoryMoveResponse.Corresponds to gravitational/webapps#1045