SharedDirectoryWriteResponse

[ibeckermayer]

Requires backport to v9/v10

How to test manually

webapps

1. Change the value below to true

   webapps/packages/teleport/src/config.ts

   Line 32 in becfad3

   enableDirectorySharing: false, // note to reviewers: should be false in any PRs.

2. run the development server like yarn start-teleport --target=https://ec2-35-171-27-185.compute-1.amazonaws.com/
3. See https://gravitational.slack.com/archives/C02DQ1C2BMW/p1657807702085829 for a username/password combo

What to expect

Go to the top right ... menu and click Share Directory

(X-out of the "uncaught exception" screen if you get it). The directory you select should show up in the File Explorer as a shared drive

The drive should be navigable as well should any folders within it

Trying to open a file should show you the file contents (if you open it in Notepad for example). You will be able to type into the file, and if you save the file the changes should show up on your local disk.

[kimlisa]

resizing isn't possible yet right?

[kimlisa]

the handleSharedDirectoryListRequest (below) has a try/catch block and calls handleError, does this block need it too?

[ibeckermayer]

Yes good catch. Typically anything that calls this.sdManager should be wrapped in try/catch

webapps/packages/teleport/src/lib/tdp/sharedDirectoryManager.ts

Lines 15 to 17 in 11eb8ed

	// SharedDirectoryManager manages a FileSystemDirectoryHandle for use
	// by the TDP client. Most of it's methods can potentially throw errors
	// and so should be wrapped in try/catch blocks.

[kimlisa]

was that document is not focused error happening during directory sharing? b/c i get that error even when i'm not sharing (but i don't remember the original discussion).

[ibeckermayer]

resizing isn't possible yet right?

correct

was that document is not focused error happening during directory sharing? b/c i get that error even when i'm not sharing (but i don't remember the original discussion).

Yes that error was only ever happening for me right around when I started directory sharing. You're seeing it while just clicking around the interface while not directory sharing?

@lisa

[lisa]

resizing isn't possible yet right?

correct

was that document is not focused error happening during directory sharing? b/c i get that error even when i'm not sharing (but i don't remember the original discussion).

Yes that error was only ever happening for me right around when I started directory sharing. You're seeing it while just clicking around the interface while not directory sharing?

@lisa

@lisa User Notification

Hello! You're receiving this notice because you've tagged me, @lisa, on GitHub, likely in error. Lisa is a common first name, and happens to be mine. I use the @lisa username here on GitHub. While being tagged in various repositories is an interesting way for me to discover new projects, it's likely not your intention. Did you mean to tag someone else? Did you mean to use @lisa instead, in a word as word usage?

Next Steps

I'm unsubscribing from this issue, pull request or project so if you meant to tag someone else to notify them, I would recommend that. If you meant to use my user ID as a plain string, without having GitHub notify me, you can do so by wrapping with backticks (the ` character), like so: @lisa.