This repository was archived by the owner on Feb 8, 2024. It is now read-only.
SharedDirectoryCreateRequest and SharedDirectoryCreateResponse#1090
Merged
ibeckermayer merged 11 commits intomasterfrom Aug 9, 2022
Merged
SharedDirectoryCreateRequest and SharedDirectoryCreateResponse#1090ibeckermayer merged 11 commits intomasterfrom
SharedDirectoryCreateRequest and SharedDirectoryCreateResponse#1090ibeckermayer merged 11 commits intomasterfrom
Conversation
added 7 commits
August 4, 2022 14:28
…working. Directories get created but their contents isn't copied over. Next, check to confirm that native RDP clients copy the contents of directories as well. (Has console.log statements).
…all console.log statements
ibeckermayer
requested review from
JanKaczmarkiewicz,
gzdunek,
hatched,
kimlisa,
rudream and
zmb3
hatched
approved these changes
Aug 8, 2022
ibeckermayer
pushed a commit
that referenced
this pull request
Aug 23, 2022
ibeckermayer
pushed a commit
that referenced
this pull request
Aug 24, 2022
* `SharedDirectoryInfoResponse` (#996) * `SharedDirectoryListRequest` (#999) * `SharedDirectoryListResponse` (#1000) * `SharedDirectoryReadRequest` (#1003) * `SharedDirectoryReadResponse` (#1005) * `SharedDirectoryWriteRequest` (#1007) * `SharedDirectoryWriteResponse` (#1008) * Tidy up `sharedDirectoryManager` (#1010) * `SharedDirectoryMoveRequest` (#1045) * `SharedDirectoryMoveResponse` (#1074) * `SharedDirectoryCreateRequest` and `SharedDirectoryCreateResponse` (#1090) * SharedDirectoryDeleteRequest and SharedDirectoryDeleteResponse (#1096) * Add warning dialog for unsupported browsers for directory sharing (#1110) * updates yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the TDP messages and
SharedDirectoryManagermethod necessary to allow users to copy files and directories into the shared directory.You should now be able to:
Moving files and directories from the shared directory still won't work, since it requires unimplemented
SharedDirectoryDeletemessages.Corresponds with: gravitational/teleport#15289
Requires backport to v9/v10
How to test manually
webappstruewebapps/packages/teleport/src/config.ts
Line 32 in becfad3
yarn start-teleport --target=https://ec2-35-171-27-185.compute-1.amazonaws.com/What to expect
Go to the top right
...menu and clickShare Directory(X-out of the "uncaught exception" screen if you get it). The directory you select should show up in the File Explorer as a shared drive
The drive should be navigable as well should any folders within it