This repository was archived by the owner on Feb 8, 2024. It is now read-only.
SharedDirectoryMoveResponse#1074
Merged
ibeckermayer merged 12 commits intomasterfrom Aug 5, 2022
Merged
Conversation
added 4 commits
July 28, 2022 20:03
ibeckermayer
requested review from
JanKaczmarkiewicz,
gzdunek,
hatched,
kimlisa,
ravicious,
rudream and
zmb3
kimlisa
reviewed
Aug 4, 2022
| } else if (clipboardError) { | ||
| errorText = clipboardState.errorText || 'clipboard sharing failed'; | ||
| } else if (unknownConnectionError) { | ||
| errorText = 'Session disconnected for an unknown reason'; |
Contributor
There was a problem hiding this comment.
Suggested change
| errorText = 'Session disconnected for an unknown reason'; | |
| errorText = 'Session disconnected for an unknown reason. Try reloading (or refreshing) the browser.'; |
and then the button could say Reload or Refresh?
also i'm confused whether our error messages should be all lower cap or properly capitalized with punctuation. I'm just seeing a mixture of both. It's not a big deal to me but just wondering in general
Author
There was a problem hiding this comment.
also i'm confused whether our error messages should be all lower cap or properly capitalized with punctuation.
In my opinion if we're displaying it as a message to the user, we should strive to give it proper capitalization and punctuation.
| } | ||
|
|
||
| // | message type (24) | completion_id uint32 | err_code uint32 | | ||
| encodeSharedDirectoryMoveResponse(res: SharedDirectoryMoveResponse): Message { |
Contributor
There was a problem hiding this comment.
What do you think of an declarative approach for encoding similar to #1003 (comment)
Author
There was a problem hiding this comment.
Great idea. I've added it as an issue: https://github.com/gravitational/webapps/issues/1087
kimlisa
approved these changes
Aug 5, 2022
ibeckermayer
pushed a commit
that referenced
this pull request
Aug 24, 2022
* `SharedDirectoryInfoResponse` (#996) * `SharedDirectoryListRequest` (#999) * `SharedDirectoryListResponse` (#1000) * `SharedDirectoryReadRequest` (#1003) * `SharedDirectoryReadResponse` (#1005) * `SharedDirectoryWriteRequest` (#1007) * `SharedDirectoryWriteResponse` (#1008) * Tidy up `sharedDirectoryManager` (#1010) * `SharedDirectoryMoveRequest` (#1045) * `SharedDirectoryMoveResponse` (#1074) * `SharedDirectoryCreateRequest` and `SharedDirectoryCreateResponse` (#1090) * SharedDirectoryDeleteRequest and SharedDirectoryDeleteResponse (#1096) * Add warning dialog for unsupported browsers for directory sharing (#1110) * updates yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately when doing research for this feature, I failed to notice that the browser API I was planning to use for moving files and directories was unfinished #1064.
In the meantime, I've decided to make all error notifications show up in a modal (instead of a banner), and make a distinction between fatal and non-fatal errors, with non-fatal errors being displayed as a dismissible modal
and fatal errors showing up as a modal with a button that allows you to refresh the page
(See the video at the very bottom of this description for the modals in action).
Playback is currently unaffected by these changes, because directory sharing events are not captured or played back, the only non-fatal error is thrown by a directory sharing message. When this changes, we may need to refactor the playback system to handle non-fatal errors accurately.
Requires backport to v9/v10
closes #615
How to test manually
webappstruewebapps/packages/teleport/src/config.ts
Line 32 in becfad3
yarn start-teleport --target=https://ec2-35-171-27-185.compute-1.amazonaws.com/What to expect
Go to the top right
...menu and clickShare Directory(X-out of the "uncaught exception" screen if you get it). The directory you select should show up in the File Explorer as a shared drive
The drive should be navigable as well should any folders within it
Try moving the file from one folder in the shared directory to another, and you should see something like
sd-move-response.mov