This repository was archived by the owner on Feb 8, 2024. It is now read-only.
Tidy up sharedDirectoryManager#1010
Merged
ibeckermayer merged 56 commits intomasterfrom Jul 28, 2022
Merged
Conversation
added 30 commits
July 6, 2022 15:53
… previously janky validity checks
… previously janky validity checks
…-file-system-access
added 15 commits
July 18, 2022 17:38
…client which converts it to a FileSystemObject
…wever for big directories (like node_modules) this takes forever. Going to try a non-Promise.all version
… and ensures all throws are handled
hatched
approved these changes
Jul 21, 2022
ibeckermayer
force-pushed
the
isaiah/tidy-up-sdm
branch
from
a24434c to
eb7b04a
Compare
kimlisa
approved these changes
Jul 27, 2022
Contributor
kimlisa
left a comment
kimlisa
left a comment
There was a problem hiding this comment.
the only thing that didn't work for me was the copy and paste feature
ibeckermayer
pushed a commit
that referenced
this pull request
Aug 23, 2022
ibeckermayer
pushed a commit
that referenced
this pull request
Aug 24, 2022
* `SharedDirectoryInfoResponse` (#996) * `SharedDirectoryListRequest` (#999) * `SharedDirectoryListResponse` (#1000) * `SharedDirectoryReadRequest` (#1003) * `SharedDirectoryReadResponse` (#1005) * `SharedDirectoryWriteRequest` (#1007) * `SharedDirectoryWriteResponse` (#1008) * Tidy up `sharedDirectoryManager` (#1010) * `SharedDirectoryMoveRequest` (#1045) * `SharedDirectoryMoveResponse` (#1074) * `SharedDirectoryCreateRequest` and `SharedDirectoryCreateResponse` (#1090) * SharedDirectoryDeleteRequest and SharedDirectoryDeleteResponse (#1096) * Add warning dialog for unsupported browsers for directory sharing (#1110) * updates yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires backport to v9/v10