This repository was archived by the owner on Feb 8, 2024. It is now read-only.
SharedDirectoryInfoResponse#996
Merged
ibeckermayer merged 47 commits intomasterfrom Jul 27, 2022
Merged
Conversation
added 30 commits
July 6, 2022 15:53
… previously janky validity checks
… previously janky validity checks
…-file-system-access
added 10 commits
July 18, 2022 16:11
ibeckermayer
requested review from
JanKaczmarkiewicz,
hatched,
kimlisa,
ravicious,
rudream and
zmb3
ibeckermayer
commented
Jul 19, 2022
hatched
approved these changes
Jul 21, 2022
kimlisa
approved these changes
Jul 27, 2022
Co-authored-by: Lisa Kim <lisa@goteleport.com>
ibeckermayer
pushed a commit
that referenced
this pull request
Aug 23, 2022
ibeckermayer
pushed a commit
that referenced
this pull request
Aug 24, 2022
* `SharedDirectoryInfoResponse` (#996) * `SharedDirectoryListRequest` (#999) * `SharedDirectoryListResponse` (#1000) * `SharedDirectoryReadRequest` (#1003) * `SharedDirectoryReadResponse` (#1005) * `SharedDirectoryWriteRequest` (#1007) * `SharedDirectoryWriteResponse` (#1008) * Tidy up `sharedDirectoryManager` (#1010) * `SharedDirectoryMoveRequest` (#1045) * `SharedDirectoryMoveResponse` (#1074) * `SharedDirectoryCreateRequest` and `SharedDirectoryCreateResponse` (#1090) * SharedDirectoryDeleteRequest and SharedDirectoryDeleteResponse (#1096) * Add warning dialog for unsupported browsers for directory sharing (#1110) * updates yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides adding the plumbing for
SharedDirectoryInfoResponse, this PR also creates a new classSharedDirectoryManagerfor managing access into theFileSystemDirectoryHandlethat represents the directory being shared. It is written in such a way that it will be easy to extend to share multiple directories at once.Unfortunately I wasn't able to test it with
Jest, see the Slack thread here for details. I did however manually hardcode various paths to confirm thatSharedDirectoryManager.walkPathis working as expected.Requires backport to v9/v10
How to test manually
webappstruewebapps/packages/teleport/src/config.ts
Line 32 in becfad3
yarn start-teleport --target=https://ec2-35-171-27-185.compute-1.amazonaws.com/What to expect
Go to the top right
...menu and clickShare Directory(X-out of the "uncaught exception" screen if you get it). The directory you select should show up in the File Explorer as a shared drive
Navigating to the shared drive should give you