Skip to content

Fix numerous blend space issues#119029

Closed
Ryan-000 wants to merge 1 commit into
godotengine:masterfrom
Ryan-000:fix-animation-blendspace-problems
Closed

Fix numerous blend space issues#119029
Ryan-000 wants to merge 1 commit into
godotengine:masterfrom
Ryan-000:fix-animation-blendspace-problems

Conversation

@Ryan-000
Copy link
Copy Markdown
Contributor

Resolves #118945 #118982

@Ryan-000 Ryan-000 requested review from a team as code owners April 28, 2026 03:34
@Ryan-000 Ryan-000 force-pushed the fix-animation-blendspace-problems branch from ed13953 to aee8085 Compare April 28, 2026 03:38
Copy link
Copy Markdown
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it appears to contain numerous changes beyond the fixes for the reported issues, you need to split it up; Since now is the beta phase, only fixes for avoiding crash should be applied here. You can create a separate PR or modify this PR that addresses only the BlendSpace1D/2D "Editor" crash fix (so I assume we should change only BlendSpace1D/2DEditor class not BlendSpace1D/2D class). See also #118970 to avoid conflict/duplication with that.

If you really need to make changes, you must provide a detailed explanation of the cause and the solution in the description. This PR appears to make overly fundamental changes to address the issue.

@vaner-org
Copy link
Copy Markdown
Contributor

No conflicts with #118970, that one only targets editors, this one mostly targets resources.

@fire
Copy link
Copy Markdown
Member

fire commented Apr 28, 2026

The changes are too scattered, I can't tell the logical reason for the changes linked to a bug report.

@Ryan-000 Ryan-000 closed this Apr 28, 2026
@AThousandShips AThousandShips removed this from the 4.x milestone Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor crashes if you undo an action while outside of BlendSpace1D/BlendSpace2D editors

6 participants