Improve conditionals across AnimationTree#118970
Open
vaner-org wants to merge 1 commit into
Open
Conversation
5040662 to
a8f0822
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #109792.
The triangle tool in BlendSpace2D's editor has a few problems.
The rest of the improvements serve as a succession of #110369, which moved editor-specific tools to the left side of the toolbar and edited item-specific tools to the right, only for BlendSpaces. This PR finishes that job, with some considerations.
While the last one has been fixed correctly, the whole block can't be removed yet. The broken feature that it tried to add is possible to fix with a refactor of selection in StateMachine that is ready to follow this PR, that will allow for both shift-clicking to add nodes to selection as well as shift-dragging to move them, by deferring to mouseup and mouse drag.
Even though feature freeze is on, almost all of the above lead to unexpected dead ends, broken functionality, or errors. The refactor has been held back so that this may have a chance to make it to 4.7 to accompany #110369. If that isn't possible, I can split up what can make it, and save the rest and the refactor for later.