Skip to content

Fix undo crash when animation editor is not active#119061

Merged
Repiteo merged 1 commit into
godotengine:masterfrom
Ryan-000:fix-animation-1
Apr 30, 2026
Merged

Fix undo crash when animation editor is not active#119061
Repiteo merged 1 commit into
godotengine:masterfrom
Ryan-000:fix-animation-1

Conversation

@Ryan-000
Copy link
Copy Markdown
Contributor

Split from #119029
Resolves #118945

Comment thread editor/animation/animation_blend_space_1d_editor.cpp
@TokageItLab
Copy link
Copy Markdown
Member

Also fixes #118982 ?

@Repiteo Repiteo requested a review from matheusmdx April 29, 2026 17:39
@matheusmdx
Copy link
Copy Markdown
Contributor

Also fixes #118982 ?

Unfortunatelly this PR do not fix #118982 (but fixes the target issue, #118945). They look similar but each one generate different backtraces, started in different versions and #118982 happens specifically with the first added point.

2026-04-29.20-00-43.mp4

@Repiteo Repiteo merged commit 903644e into godotengine:master Apr 30, 2026
20 checks passed
@Repiteo
Copy link
Copy Markdown
Contributor

Repiteo commented Apr 30, 2026

Thanks!

@Ryan-000
Copy link
Copy Markdown
Contributor Author

Also fixes #118982 ?

#119070 will directly resolve the crashing (I have updated that PR description to include the issue link).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor crashes if you undo an action while outside of BlendSpace1D/BlendSpace2D editors

4 participants