Validate name in add_blend_point and forbid duplicates#119066
Open
Ryan-000 wants to merge 1 commit into
Open
Conversation
Name validation is already done in `set_blend_point_name` so it should be done in `add_blend_point` as well.
TokageItLab
reviewed
Apr 29, 2026
| #else | ||
| ERR_FAIL_COND(p_name == StringName()); | ||
| #endif | ||
| ERR_FAIL_COND(p_name.is_empty() || String(p_name).contains_char('.') || String(p_name).contains_char('/')); |
Member
There was a problem hiding this comment.
You should make is_valid_animation_node_name() helpers, you can refere is_valid_animation_name().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #119029
Name validation is already done in
set_blend_point_nameso it should be done inadd_blend_pointas well.Also having duplicate names will cause issues, so I've added a check for that as well.