Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LOCAL][RN][CI] Fix release scripts to use GITHUB_REF and GITHUB_REF_NAME variables #45057

Merged
merged 1 commit into from
Jun 19, 2024
Merged

[LOCAL][RN][CI] Fix release scripts to use GITHUB_REF and GITHUB_REF_NAME variables #45057

merged 1 commit into from
Jun 19, 2024

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Jun 19, 2024 •
edited
Loading

Summary:

This change fixes the publish-npm script. The documentation for GITHUB_REF and GITHUB_REF_NAME is here. Search for the two variables.

Changelog:

[Internal] - Fix Release scripts

Test Plan:

Added a JS test + test in prod! 😄

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jun 19, 2024
@cipolleschi cipolleschi changed the base branch from main to 0.75-stable June 19, 2024 09:28
@cipolleschi cipolleschi marked this pull request as ready for review June 19, 2024 09:30
@cortinico cortinico merged commit 375c884 into 0.75-stable Jun 19, 2024
17 of 31 checks passed
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,443,779 -16,464
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,642,465 -16,442
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: d8739e1
Branch: main

This was referenced Jun 24, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@cipolleschi cipolleschi mentioned this pull request Jul 9, 2024
Open
@cipolleschi cipolleschi mentioned this pull request Jul 29, 2024
Merged
This was referenced Aug 15, 2024
Merged
Merged
@cipolleschi cipolleschi mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cipolleschi @analysis-bot @cortinico @facebook-github-bot