Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RN][CI] Factor out build hermesc apple #45341

Open
wants to merge 1 commit into
base: 0.75-stable
Choose a base branch
from
Open

[RN][CI] Factor out build hermesc apple #45341

wants to merge 1 commit into from

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Jul 9, 2024 •
edited
Loading

Summary:

Refactor the Build HermesC apple job so to use the same code in all the jobs

Changelog:

[Internal] - CI refactoring for build hermesc apple

Test Plan:

GHA must be green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 9, 2024
@cipolleschi cipolleschi changed the base branch from main to 0.75-stable July 9, 2024 10:02
@cipolleschi cipolleschi changed the title RN][CI] Factor out build hermesc apple [RN][CI] Factor out build hermesc apple Jul 9, 2024
@cipolleschi cipolleschi marked this pull request as ready for review July 9, 2024 10:03
@cipolleschi cipolleschi force-pushed the cipolleschi/factor-out-build-hermesc-apple branch 3 times, most recently from 87c8184 to 88354f8 Compare July 9, 2024 10:09
@cipolleschi cipolleschi force-pushed the cipolleschi/factor-out-build-hermesc-apple branch from 88354f8 to 27a89a2 Compare July 9, 2024 10:26
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,443,805 -840,334
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,642,493 -838,672
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 12b64b7
Branch: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cipolleschi @analysis-bot @facebook-github-bot