Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][CI] Zip slices to preserve symlinks #46301

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Sep 2, 2024

Summary:

This change should fix #46213. We are trying to zip the folders generated by the CI and to upload the zip files as artifacts.

The zip should preserve the symlink and Github actions should not manipulate them.

Changelog:

[Internal] - Zip slices on CI to preserve symlinks

Test Plan:

GHA

@cipolleschi cipolleschi changed the base branch from main to 0.75-stable September 2, 2024 14:18
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 2, 2024
@react-native-bot
Copy link
Collaborator

Fails
🚫

📋 Verify Changelog Format - See Changelog format

Generated by 🚫 dangerJS against eda7be9

@analysis-bot
Copy link

analysis-bot commented Sep 2, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 20,743,782 -611,074
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 23,945,530 -604,461
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: fcd526d
Branch: main

@cipolleschi cipolleschi force-pushed the cipolleschi/fix-symlinks branch from c17e42e to 117cdbc Compare September 3, 2024 11:48
@cipolleschi cipolleschi marked this pull request as ready for review September 3, 2024 11:57
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-symlinks branch from 117cdbc to 9e98346 Compare September 8, 2024 11:58
@cipolleschi cipolleschi merged commit 8c732dd into 0.75-stable Sep 11, 2024
89 of 91 checks passed
@cipolleschi cipolleschi deleted the cipolleschi/fix-symlinks branch September 11, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants